Support @NoInline for constructor bodies.

pkg/compiler/lib/src/js_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 const VERBOSE_OPTIMIZER_HINTS = false;
 
 const bool USE_CPS_IR = const bool.fromEnvironment("USE_CPS_IR");
 
@@ skipping 30 matching lines @@
 
   final Map<FunctionElement, int> _cachedDecisions =
       new Map<FunctionElement, int>();
 
   // Returns `true`/`false` if we have a cached decision.
   // Returns `null` otherwise.
   bool canInline(FunctionElement element, {bool insideLoop}) {
     int decision = _cachedDecisions[element];
 
     if (decision == null) {
-      decision = _unknown;
+      // These synthetic elements are not yet present when we initially compute
+      // this cache from metadata annotations, so look for their parent

[floitsch, 2015/03/10 17:42:27]

missing ".".

[herhut, 2015/03/11 14:01:56]

Done.

+      if (element is ConstructorBodyElement) {
+        ConstructorBodyElement body = element;
+        decision = _cachedDecisions[body.constructor];
+        print("checked for $element as $decision via ${body.constructor}");

[floitsch, 2015/03/10 17:42:27]

remove print.

[herhut, 2015/03/11 14:01:56]

Done.

+      }
+      if (decision == null) {
+        decision = _unknown;
+      }
     }
 
     if (insideLoop) {
       switch (decision) {
         case _mustNotInline:
           return false;
 
         case _unknown:
         case _mayInlineInLoopMustNotOutside:
           // We know we can't inline outside a loop, but don't know for the
@@ skipping 2364 matching lines @@
               new CodegenRegistry(compiler,
                   dependency.annotatedElement.analyzableElement.treeElements));
         }
         metadataConstants.clear();
       }
     }
     return true;
   }
 
   void onElementResolved(Element element, TreeElements elements) {
-    if (element.isFunction && annotations.noInline(element)) {
+    if ((element.isFunction || element.isGenerativeConstructor) &&
+        annotations.noInline(element)) {
       inlineCache.markAsNonInlinable(element);
     }
 
     LibraryElement library = element.library;
     if (!library.isPlatformLibrary && !library.canUseNative) return;
     bool hasNoInline = false;
     bool hasForceInline = false;
     bool hasNoThrows = false;
     bool hasNoSideEffects = false;
     for (MetadataAnnotation metadata in element.metadata) {
@@ skipping 387 matching lines @@
   }
 }
 
 /// Records that [constant] is used by the element behind [registry].
 class Dependency {
   final ConstantValue constant;
   final Element annotatedElement;
 
   const Dependency(this.constant, this.annotatedElement);
 }