Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 98643003: Translate new UX: Fix the visual and behavior of 'Done' button (Closed)

Created:
7 years ago by hajimehoshi
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Translate new UX: Fix the visual and behavior of 'Done' button The label is 'Translate' only when the page is not translated in the current language pair, otherwise 'Done'. When the label is 'Translate', the view state transits to 'Translating' from 'Advanced' after clicking the button, while when 'Done', this transits to the previous view state. BUG=324696 TEST=unit_tests --gtest_filter=TranslateBubbleViewTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238597

Patch Set 1 #

Total comments: 2

Patch Set 2 : sky's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -9 lines) Patch
M chrome/browser/ui/translate/translate_bubble_model.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/translate/translate_bubble_model_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/translate/translate_bubble_model_impl.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 5 chunks +26 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc View 1 6 chunks +40 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hajimehoshi
Can you take a look? Thank you in advance.
7 years ago (2013-12-02 08:46:37 UTC) #1
sky
https://codereview.chromium.org/98643003/diff/1/chrome/browser/ui/translate/translate_bubble_model.h File chrome/browser/ui/translate/translate_bubble_model.h (right): https://codereview.chromium.org/98643003/diff/1/chrome/browser/ui/translate/translate_bubble_model.h#newcode89 chrome/browser/ui/translate/translate_bubble_model.h:89: virtual bool IsPageTranslatedInCurrentPair() const = 0; 'pair'? No where ...
7 years ago (2013-12-02 21:43:58 UTC) #2
hajimehoshi
Thank you! https://codereview.chromium.org/98643003/diff/1/chrome/browser/ui/translate/translate_bubble_model.h File chrome/browser/ui/translate/translate_bubble_model.h (right): https://codereview.chromium.org/98643003/diff/1/chrome/browser/ui/translate/translate_bubble_model.h#newcode89 chrome/browser/ui/translate/translate_bubble_model.h:89: virtual bool IsPageTranslatedInCurrentPair() const = 0; On ...
7 years ago (2013-12-03 03:26:05 UTC) #3
sky
LGTM
7 years ago (2013-12-03 17:23:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/98643003/20001
7 years ago (2013-12-04 03:54:35 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-04 06:13:31 UTC) #6
Message was sent while issue was closed.
Change committed as 238597

Powered by Google App Engine
This is Rietveld 408576698