chrome/browser/ui/views/translate/translate_bubble_view.h - Issue 98643003: Translate new UX: Fix the visual and behavior of 'Done' button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.h

Issue 98643003: Translate new UX: Fix the visual and behavior of 'Done' button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sky's review Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/translate/translate_bubble_model_impl.cc ('k') | chrome/browser/ui/views/translate/translate_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_bubble_view.h

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.h b/chrome/browser/ui/views/translate/translate_bubble_view.h

index bb070200a92a722e975dc9f5ffa6b8a9996bba7d..50ee1fb35086605635b338872aa4a7cf8fc3535b 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view.h

+++ b/chrome/browser/ui/views/translate/translate_bubble_view.h

@@ -108,6 +108,8 @@ class TranslateBubbleView : public views::BubbleDelegateView,

AlwaysTranslateCheckboxAndDoneButton);

FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest, DoneButton);

FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,

+ DoneButtonWithoutTranslating);

+ FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,

CancelButtonReturningBeforeTranslate);

FRIEND_TEST_ALL_PREFIXES(TranslateBubbleViewTest,

CancelButtonReturningAfterTranslate);

@@ -174,6 +176,9 @@ class TranslateBubbleView : public views::BubbleDelegateView,

views::Checkbox* always_translate_checkbox_;

+ views::LabelButton* advanced_cancel_button_;

+ views::LabelButton* advanced_done_button_;

scoped_ptr<TranslateBubbleModel> model_;

// Whether the window is an incognito window.