Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 983973002: Revert of Refactor the loading tracking logic in WebContentsImpl. (Closed)

Created:
5 years, 9 months ago by tasak
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor the loading tracking logic in WebContentsImpl. (patchset #17 id:320001 of https://codereview.chromium.org/925623002/) Reason for revert: This patch causes the following layout tests' crashes: - fast/loader/stateobjects/replacestate-in-onunload.html: 2921 2922 // This method should never be called when the frame is loading. 2923 DCHECK(!rfh->is_loading()); 2924 #3 0x00007fffefece2d3 in content::WebContentsImpl::OnDidStartLoading ( this=0x181e00571b20, to_different_document=false) at ../../content/browser/web_contents/web_contents_impl.cc:2923 #4 0x00007fffefefa3e7 in DispatchToMethodImpl<content::WebContentsImpl, void (content::WebContentsImpl::*)(bool), bool, 0ul> (obj=0x181e00571b20, method= (void (content::WebContentsImpl::*)(content::WebContentsImpl * const, bool)) 0x7fffefece170 <content::WebContentsImpl::OnDidStartLoading(bool)>, arg=...) at ../../base/tuple.h:246 #5 0x00007fffefefa335 in DispatchToMethod<content::WebContentsImpl, void (content::WebContentsImpl::*)(bool), bool> (obj=0x181e00571b20, method= (void (content::WebContentsImpl::*)(content::WebContentsImpl * const, bool)) 0x7fffefece170 <content::WebContentsImpl::OnDidStartLoading(bool)>, arg=...) at ../../base/tuple.h:253 #6 0x00007fffefee4bf7 in FrameHostMsg_DidStartLoading::Dispatch<content::WebContentsImpl, content::WebContentsImpl, void, void (content::WebContentsImpl::*)(bool)> (msg=0x181e006fddd0, obj=0x181e00571b20, sender=0x181e00571b20, parameter=0x0, func= c.f. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/19986 Original issue's description: > Refactor the loading tracking logic in WebContentsImpl. > > This removes the loading_progresses_ map and the > loading_frames_in_progress counter in WebContentsImpl. > Instead, tracking of these is done at the RFHI level. > > BUG=429399 > > Committed: https://crrev.com/bda82dd8f2286787212cb92c694a999f08834c7b > Cr-Commit-Position: refs/heads/master@{#319267} TBR=clamy@chromium.org,carlosk@chromium.org,nasko@chromium.org,creis@chromium.org,fdegans@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=429399 Committed: https://crrev.com/de32453de06c421e479ad5aa91ac07018c298d01 Cr-Commit-Position: refs/heads/master@{#319432}

Patch Set 1 #

Patch Set 2 : Fixed patch conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -202 lines) Patch
M content/browser/frame_host/frame_tree_node.h View 1 4 chunks +18 lines, -7 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 2 chunks +2 lines, -23 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 3 chunks +0 lines, -36 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 10 chunks +59 lines, -66 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 1 chunk +0 lines, -64 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tasak
Created Revert of Refactor the loading tracking logic in WebContentsImpl.
5 years, 9 months ago (2015-03-06 03:54:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983973002/1
5 years, 9 months ago (2015-03-06 03:54:35 UTC) #2
commit-bot: I haz the power
Failed to apply patch for content/browser/frame_host/frame_tree_node.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-06 03:54:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983973002/90002
5 years, 9 months ago (2015-03-06 10:39:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:90002)
5 years, 9 months ago (2015-03-06 10:40:00 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/de32453de06c421e479ad5aa91ac07018c298d01 Cr-Commit-Position: refs/heads/master@{#319432}
5 years, 9 months ago (2015-03-06 10:40:49 UTC) #9
Fabrice (no longer in Chrome)
5 years, 9 months ago (2015-03-06 15:15:53 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:90002) has been created in
https://codereview.chromium.org/989473003/ by fdegans@chromium.org.

The reason for reverting is: Reland following
https://codereview.chromium.org/984983002/ landing in blink..

Powered by Google App Engine
This is Rietveld 408576698