DescriptionRevert of Refactor the loading tracking logic in WebContentsImpl. (patchset #17 id:320001 of https://codereview.chromium.org/925623002/)
Reason for revert:
This patch causes the following layout tests' crashes:
- fast/loader/stateobjects/replacestate-in-onunload.html:
2921
2922 // This method should never be called when the frame is loading.
2923 DCHECK(!rfh->is_loading());
2924
#3 0x00007fffefece2d3 in content::WebContentsImpl::OnDidStartLoading (
this=0x181e00571b20, to_different_document=false)
at ../../content/browser/web_contents/web_contents_impl.cc:2923
#4 0x00007fffefefa3e7 in DispatchToMethodImpl<content::WebContentsImpl, void (content::WebContentsImpl::*)(bool), bool, 0ul> (obj=0x181e00571b20, method=
(void (content::WebContentsImpl::*)(content::WebContentsImpl * const, bool)) 0x7fffefece170 <content::WebContentsImpl::OnDidStartLoading(bool)>, arg=...)
at ../../base/tuple.h:246
#5 0x00007fffefefa335 in DispatchToMethod<content::WebContentsImpl, void (content::WebContentsImpl::*)(bool), bool> (obj=0x181e00571b20, method=
(void (content::WebContentsImpl::*)(content::WebContentsImpl * const, bool)) 0x7fffefece170 <content::WebContentsImpl::OnDidStartLoading(bool)>, arg=...)
at ../../base/tuple.h:253
#6 0x00007fffefee4bf7 in FrameHostMsg_DidStartLoading::Dispatch<content::WebContentsImpl, content::WebContentsImpl, void, void (content::WebContentsImpl::*)(bool)> (msg=0x181e006fddd0, obj=0x181e00571b20, sender=0x181e00571b20,
parameter=0x0, func=
c.f. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/19986
Original issue's description:
> Refactor the loading tracking logic in WebContentsImpl.
>
> This removes the loading_progresses_ map and the
> loading_frames_in_progress counter in WebContentsImpl.
> Instead, tracking of these is done at the RFHI level.
>
> BUG=429399
>
> Committed: https://crrev.com/bda82dd8f2286787212cb92c694a999f08834c7b
> Cr-Commit-Position: refs/heads/master@{#319267}
TBR=clamy@chromium.org,carlosk@chromium.org,nasko@chromium.org,creis@chromium.org,fdegans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=429399
Committed: https://crrev.com/de32453de06c421e479ad5aa91ac07018c298d01
Cr-Commit-Position: refs/heads/master@{#319432}
Patch Set 1 #Patch Set 2 : Fixed patch conflict #
Messages
Total messages: 10 (3 generated)
|