Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 983973002: Revert of Refactor the loading tracking logic in WebContentsImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed patch conflict Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/frame_tree_node.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index c6a6c6e1ea0114e44ca8b88a6306f9991592df28..178eb326d73a826d24c332112c0d791e5ebf24f8 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -95,15 +95,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
: public RenderFrameHost,
public BrowserAccessibilityDelegate {
public:
- // These values indicate the loading progress status. The minimum progress
- // value matches what Blink's ProgressTracker has traditionally used for a
- // minimum progress value.
- // TODO(fdegans): Move these values to the implementation when the relevant
- // IPCs are moved from WebContentsImpl to RenderFrameHost.
- static const double kLoadingProgressNotStarted;
- static const double kLoadingProgressMinimum;
- static const double kLoadingProgressDone;
-
// Keeps track of the state of the RenderFrameHostImpl, particularly with
// respect to swap out.
enum RenderFrameHostImplState {
@@ -213,26 +204,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
RenderFrameHostDelegate* delegate() { return delegate_; }
FrameTreeNode* frame_tree_node() { return frame_tree_node_; }
- // Sets this RenderFrameHost's loading state.
- void set_is_loading(bool is_loading) {
- is_loading_ = is_loading;
- }
-
- // Returns this RenderFrameHost's loading state. This method is only used by
- // FrameTreeNode. The proper way to check whether a frame is loading is to
- // call FrameTreeNode::IsLoading.
- bool is_loading() const { return is_loading_; }
-
- // Sets this RenderFrameHost's loading progress (from 0 to 1).
- void set_loading_progress(double loading_progress) {
- loading_progress_ = loading_progress;
- }
-
- // Returns this RenderFrameHost's loading progress. This is only used by
- // FrameTreeNode. The proper way to check a frame loading progress is to call
- // FrameTreeNode::GetLoadingProgress.
- double loading_progress() const { return loading_progress_; }
-
// This returns the RenderFrameHost's owned RenderWidgetHost if it has one,
// or else it returns nullptr.
// If the RenderFrameHost is the page's main frame, this returns instead a
@@ -696,13 +667,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
// PlzNavigate: all navigations require a beforeUnload ACK.
bool unload_ack_is_for_navigation_;
- // Indicates whether this RenderFrameHost is in the process of loading a
- // document or not.
- bool is_loading_;
-
- // Used to track this RenderFrameHost's loading progress (from 0 to 1).
- double loading_progress_;
-
// Used to swap out or shut down this RFH when the unload event is taking too
// long to execute, depending on the number of active frames in the
// SiteInstance.
« no previous file with comments | « content/browser/frame_host/frame_tree_node.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698