Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 9838092: ui/base/models: Make ComboboxModel::GetItemCount() a constant function. (Closed)

Created:
8 years, 9 months ago by tfarina
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

ui/base/models: Make ComboboxModel::GetItemCount() a constant function. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128961 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129071

Patch Set 1 #

Patch Set 2 : fix win_rel and reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -50 lines) Patch
M chrome/browser/bookmarks/recently_used_folders_combo_model.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 5 chunks +17 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 9 chunks +27 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/cookie_info_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/cookie_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/combobox_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_views_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/views/examples/combobox_example.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/examples/example_combobox_model.h View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/examples/example_combobox_model.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M ui/views/examples/examples_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 9 months ago (2012-03-24 02:05:20 UTC) #1
sky
8 years, 9 months ago (2012-03-26 15:01:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698