Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2376)

Side by Side Diff: chrome/browser/ui/views/uninstall_view.cc

Issue 9838092: ui/base/models: Make ComboboxModel::GetItemCount() a constant function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win_rel and reland Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/uninstall_view.h ('k') | ui/base/models/combobox_model.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/uninstall_view.h" 5 #include "chrome/browser/ui/views/uninstall_view.h"
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "base/process_util.h" 8 #include "base/process_util.h"
9 #include "base/string16.h" 9 #include "base/string16.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 } 135 }
136 136
137 string16 UninstallView::GetWindowTitle() const { 137 string16 UninstallView::GetWindowTitle() const {
138 return l10n_util::GetStringUTF16(IDS_UNINSTALL_CHROME); 138 return l10n_util::GetStringUTF16(IDS_UNINSTALL_CHROME);
139 } 139 }
140 140
141 views::View* UninstallView::GetContentsView() { 141 views::View* UninstallView::GetContentsView() {
142 return this; 142 return this;
143 } 143 }
144 144
145 int UninstallView::GetItemCount() { 145 int UninstallView::GetItemCount() const {
146 DCHECK(!browsers_->empty()); 146 DCHECK(!browsers_->empty());
147 return browsers_->size(); 147 return browsers_->size();
148 } 148 }
149 149
150 string16 UninstallView::GetItemAt(int index) { 150 string16 UninstallView::GetItemAt(int index) {
151 DCHECK_LT(index, static_cast<int>(browsers_->size())); 151 DCHECK_LT(index, static_cast<int>(browsers_->size()));
152 BrowsersMap::const_iterator it = browsers_->begin(); 152 BrowsersMap::const_iterator it = browsers_->begin();
153 std::advance(it, index); 153 std::advance(it, index);
154 return WideToUTF16Hack((*it).first); 154 return WideToUTF16Hack((*it).first);
155 } 155 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/uninstall_view.h ('k') | ui/base/models/combobox_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698