Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: ui/views/controls/combobox/native_combobox_views_unittest.cc

Issue 9838092: ui/base/models: Make ComboboxModel::GetItemCount() a constant function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win_rel and reland Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/models/combobox_model.h ('k') | ui/views/examples/combobox_example.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/combobox/native_combobox_views_unittest.cc
diff --git a/ui/views/controls/combobox/native_combobox_views_unittest.cc b/ui/views/controls/combobox/native_combobox_views_unittest.cc
index 2474c4ad316d3d872e6e50bc3e8c807cc7e12b97..4143d221ce7f31c7a54b0c1d8171bf43a1722ed2 100644
--- a/ui/views/controls/combobox/native_combobox_views_unittest.cc
+++ b/ui/views/controls/combobox/native_combobox_views_unittest.cc
@@ -50,19 +50,20 @@ class TestCombobox : public views::Combobox {
DISALLOW_COPY_AND_ASSIGN(TestCombobox);
};
-// A concrete class is needed to test the combobox
+// A concrete class is needed to test the combo box.
class TestComboboxModel : public ui::ComboboxModel {
public:
TestComboboxModel() {}
virtual ~TestComboboxModel() {}
- virtual int GetItemCount() {
+
+ // Overridden from ui::ComboboxModel:
+ virtual int GetItemCount() const OVERRIDE {
return 4;
}
- virtual string16 GetItemAt(int index) {
- EXPECT_GE(index, 0);
- EXPECT_LT(index, GetItemCount());
+ virtual string16 GetItemAt(int index) OVERRIDE {
return string16();
}
+
private:
DISALLOW_COPY_AND_ASSIGN(TestComboboxModel);
};
« no previous file with comments | « ui/base/models/combobox_model.h ('k') | ui/views/examples/combobox_example.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698