content/browser/renderer_host/render_widget_helper.h - Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_helper.h

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised approach based on http://crrev.com/125180. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « content/browser/renderer_host/render_message_filter.cc ('k') | content/browser/renderer_host/render_widget_helper.cc » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_helper.h

diff --git a/content/browser/renderer_host/render_widget_helper.h b/content/browser/renderer_host/render_widget_helper.h

index f897984062c2eeaf13db0906a193284fba77b363..1468f6122a3aaab56a22fca92f7cdf7e3baed1f0 100644

--- a/content/browser/renderer_host/render_widget_helper.h

+++ b/content/browser/renderer_host/render_widget_helper.h

@@ -15,6 +15,7 @@

#include "base/process.h"

#include "base/synchronization/lock.h"

#include "base/synchronization/waitable_event.h"

+#include "content/public/browser/content_browser_client.h"

#include "content/public/common/window_container_type.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebPopupType.h"

#include "ui/gfx/native_widget_types.h"

@@ -127,10 +128,12 @@ class RenderWidgetHelper

// Called on the IO thread when a UpdateRect message is received.

void DidReceiveUpdateMsg(const IPC::Message& msg);

- void CreateNewWindow(const ViewHostMsg_CreateWindow_Params& params,

- base::ProcessHandle render_process,

- int* route_id,

- int* surface_id);

+ void CreateNewWindow(

+ const ViewHostMsg_CreateWindow_Params& params,

+ content::ContentBrowserClient::CanCreateWindowResult can_create_result,

+ base::ProcessHandle render_process,

+ int* route_id,

+ int* surface_id);

void CreateNewWidget(int opener_id,

WebKit::WebPopupType popup_type,

int* route_id,