Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 9836108: Rollback of r11015, r11014, r11011, r11010 in trunk branch. (Closed)

Created:
8 years, 9 months ago by danno
Modified:
8 years, 9 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Rollback of r11015, r11014, r11011, r11010 in trunk branch. Remove static Mutex from math function intializers. Use lazy instance initializer to remove static initializers in two places. Review URL: https://chromiumcodereview.appspot.com/9664067 Fix broken build on Win32 due to r11010. Review URL: https://chromiumcodereview.appspot.com/9666055 Landing for pliard@chromium.org: Remove static initializers in v8. R=fschneider@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11149

Patch Set 1 #

Patch Set 2 : Finish file upload #

Patch Set 3 : Finish file upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -1020 lines) Patch
M src/SConscript View 1 chunk +0 lines, -1 line 0 comments Download
M src/api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +18 lines, -41 lines 0 comments Download
M src/arm/assembler-arm.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 8 chunks +31 lines, -33 lines 0 comments Download
M src/assembler.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/assembler.cc View 3 chunks +16 lines, -38 lines 0 comments Download
M src/builtins.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +9 lines, -33 lines 0 comments Download
M src/flags.cc View 2 chunks +14 lines, -1 line 0 comments Download
src/frames.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/gdb-jit.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gdb-jit.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M src/heap.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +10 lines, -19 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +19 lines, -22 lines 0 comments Download
M src/isolate.h View 6 chunks +21 lines, -18 lines 0 comments Download
M src/isolate.cc View 9 chunks +60 lines, -77 lines 0 comments Download
D src/lazy-instance.h View 1 chunk +0 lines, -216 lines 0 comments Download
M src/lithium.h View 6 chunks +5 lines, -9 lines 0 comments Download
M src/lithium.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/lithium-allocator.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/log.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.cc View 4 chunks +4 lines, -6 lines 0 comments Download
D src/once.h View 1 chunk +0 lines, -123 lines 0 comments Download
D src/once.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M src/platform.h View 3 chunks +0 lines, -43 lines 0 comments Download
M src/platform-cygwin.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/platform-freebsd.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/platform-linux.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/platform-macos.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/platform-openbsd.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/platform-posix.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M src/platform-solaris.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/platform-win32.cc View 7 chunks +23 lines, -18 lines 0 comments Download
M src/runtime-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime-profiler.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/v8.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.cc View 6 chunks +10 lines, -13 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +17 lines, -35 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +15 lines, -18 lines 0 comments Download
M src/x64/disasm-x64.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +3 lines, -11 lines 0 comments Download
D tools/check-static-initializers.sh View 1 chunk +0 lines, -54 lines 0 comments Download
M tools/gyp/v8.gyp View 5 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
8 years, 9 months ago (2012-03-27 08:35:52 UTC) #1
fschneider
8 years, 9 months ago (2012-03-27 08:37:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698