Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 9834086: Revert 128763 - Broke pnacl SDK (Closed)

Created:
8 years, 9 months ago by Ryan Sleevi
Modified:
8 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 128763 - Broke pnacl SDK NaCl proxy for PPB_NetAddress_Private_1_1 Review URL: https://chromiumcodereview.appspot.com/9808028 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128766

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
Ryan Sleevi
8 years, 9 months ago (2012-03-24 19:54:03 UTC) #1
Ryan Sleevi
http://build.chromium.org/p/client.nacl.sdk/builders/pnacl-linux-sdk-multi/builds/425/steps/SDK%20Items/logs/stdio /mnt/data/b/build/slave/pnacl-linux-sdk-multi/build/src/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_net_address_private.cc:267:17: error: sizeof on array function parameter will return size of 'const uint8_t *' ...
8 years, 9 months ago (2012-03-24 19:54:40 UTC) #2
Ryan Sleevi
8 years, 9 months ago (2012-03-24 19:56:11 UTC) #3
Additional context:

Nico implemented this warning in Clang. Chromium bug fix was
http://codereview.chromium.org/7068017/ , original bug was
http://code.google.com/p/chromium/issues/detail?id=25629

Powered by Google App Engine
This is Rietveld 408576698