Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 9808028: NaCl proxy for PPB_NetAddress_Private_1_1 (Closed)

Created:
8 years, 9 months ago by Sergey Ulanov
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Dmitry Polukhin, ygorshenin1
Visibility:
Public.

Description

NaCl proxy for PPB_NetAddress_Private_1_1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128981

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages

Total messages: 7 (0 generated)
Sergey Ulanov
8 years, 9 months ago (2012-03-22 20:16:20 UTC) #1
viettrungluu
On 2012/03/22 20:16:20, sergeyu wrote: I know nothing about anything in native_client, so I'm not ...
8 years, 9 months ago (2012-03-23 03:42:17 UTC) #2
dmichael (off chromium)
lgtm
8 years, 9 months ago (2012-03-23 17:56:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9808028/5001
8 years, 9 months ago (2012-03-23 18:10:31 UTC) #4
commit-bot: I haz the power
Presubmit check for 9808028-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-23 18:10:40 UTC) #5
Dmitry Polukhin
Unfortunately such CLs need to be committed manually due to auto-generated file that violates our ...
8 years, 9 months ago (2012-03-26 07:15:08 UTC) #6
Sergey Ulanov
8 years, 9 months ago (2012-03-26 08:16:09 UTC) #7
On 2012/03/26 07:15:08, Dmitry Polukhin wrote:
> Unfortunately such CLs need to be committed manually due to auto-generated
file
> that violates our coding standards.

Yes, I realize that. I tried to land it already, but it was reverted
(https://chromiumcodereview.appspot.com/9834086/). Will reland tomorrow.

Powered by Google App Engine
This is Rietveld 408576698