Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9788001: Remove stops_event_propagation from Window, since it's broken. (Closed)

Created:
8 years, 9 months ago by Ben Goodger (Google)
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Remove stops_event_propagation from Window, since it's broken. Changes it to be implemented by the Aura client, via a new interface EventClient. The client can determine whether or not a given window and its subtree can receive events. I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell. http://crbug.com/119347 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128553

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -387 lines) Patch
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 4 chunks +5 lines, -8 lines 0 comments Download
M ash/ash.gyp View 1 3 chunks +8 lines, -0 lines 0 comments Download
M ash/shell.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 5 chunks +7 lines, -4 lines 0 comments Download
M ash/shell/app_list.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
A + ash/shell/launcher_delegate_impl.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/shell/launcher_delegate_impl.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/shell/lock_view.cc View 1 6 chunks +38 lines, -8 lines 0 comments Download
A + ash/shell/shell_delegate_impl.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/shell/shell_delegate_impl.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/shell/shell_main.cc View 1 3 chunks +6 lines, -199 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
A + ash/shell/window_watcher.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/shell/window_watcher.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/shell_delegate.h View 1 1 chunk +7 lines, -3 lines 0 comments Download
M ash/shell_unittest.cc View 1 2 chunks +3 lines, -39 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download
A + ash/wm/event_client_impl.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/wm/event_client_impl.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 1 2 chunks +17 lines, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/aura/client/event_client.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/aura/client/event_client.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 1 4 chunks +131 lines, -6 lines 0 comments Download
M ui/aura/window.h View 1 5 chunks +1 line, -23 lines 0 comments Download
M ui/aura/window.cc View 1 7 chunks +26 lines, -27 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 chunks +0 lines, -56 lines 0 comments Download
M ui/oak/oak_aura_window_display.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
8 years, 9 months ago (2012-03-21 21:57:05 UTC) #1
sky
8 years, 9 months ago (2012-03-21 22:26:26 UTC) #2 
LGTM

https://chromiumcodereview.appspot.com/9788001/diff/12003/chrome/browser/ui/v...
File chrome/browser/ui/views/ash/chrome_shell_delegate.cc (right):

https://chromiumcodereview.appspot.com/9788001/diff/12003/chrome/browser/ui/v...
chrome/browser/ui/views/ash/chrome_shell_delegate.cc:50:
g_browser_process->AddRefModule();
Remove this.

Powered by Google App Engine
This is Rietveld 408576698