Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: ui/aura/window.h

Issue 9788001: Remove stops_event_propagation from Window, since it's broken. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/root_window_unittest.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window.h
===================================================================
--- ui/aura/window.h (revision 128508)
+++ ui/aura/window.h (working copy)
@@ -218,15 +218,6 @@
void AddObserver(WindowObserver* observer);
void RemoveObserver(WindowObserver* observer);
- // When set to true, this Window will stop propagation of all events targeted
- // at Windows below it in the z-order, but only if this Window has children.
- // This is used to implement lock-screen type functionality where we do not
- // want events to be sent to running logged-in windows when the lock screen is
- // displayed.
- void set_stops_event_propagation(bool stops_event_propagation) {
- stops_event_propagation_ = stops_event_propagation;
- }
-
void set_ignore_events(bool ignore_events) { ignore_events_ = ignore_events; }
// Sets the window to grab hits for an area extending |outer| pixels outside
@@ -294,10 +285,6 @@
// Returns true if this window has a mouse capture.
bool HasCapture();
- // Returns true if this window is currently stopping event
- // propagation for any windows behind it in the z-order.
- bool StopsEventPropagation() const;
-
// Suppresses painting window content by disgarding damaged rect and ignoring
// new paint requests.
void SuppressPaint();
@@ -358,8 +345,7 @@
// If |return_tightest| is true, returns the tightest-containing (i.e.
// furthest down the hierarchy) Window containing the point; otherwise,
// returns the loosest. If |for_event_handling| is true, then hit-test masks
- // and StopsEventPropagation() are honored; otherwise, only bounds checks are
- // performed.
+ // are honored; otherwise, only bounds checks are performed.
Window* GetWindowForPoint(const gfx::Point& local_point,
bool return_tightest,
bool for_event_handling);
@@ -392,10 +378,6 @@
// Updates the layer name with a name based on the window's name and id.
void UpdateLayerName(const std::string& name);
- // Returns true if this window is behind a window that stops event
- // propagation.
- bool IsBehindStopEventsWindow() const;
-
client::WindowType type_;
WindowDelegate* delegate_;
@@ -437,10 +419,6 @@
void* user_data_;
- // When true, events are not sent to windows behind this one in the z-order,
- // provided this window has children. See set_stops_event_propagation().
- bool stops_event_propagation_;
-
// Makes the window pass all events through to any windows behind it.
bool ignore_events_;
« no previous file with comments | « ui/aura/root_window_unittest.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698