Issue 9733023: Fix crash in TabContentsViewViews::Focus. This was caused by r125126. The subtle bug is that the Sa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9733023: Fix crash in TabContentsViewViews::Focus. This was caused by r125126. The subtle bug is that the Sa… (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix crash in TabContentsViewViews::Focus. This was caused by r125126. The subtle bug is that the SadTabHelper's Observe function use to reset TabContentsViewView's Widget pointer before it deleted the sad tab Widget. With my change, TabContentsViewWin would call SadTabHelper in the middle of its sad_tab_.reset() call and would use a Widget that's being destructed. BUG=117668 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127686

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/ui/sad_tab_helper.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages