chrome/browser/ui/sad_tab_helper.cc - Issue 9733023: Fix crash in TabContentsViewViews::Focus. This was caused by r125126. The subtle bug is that the Sa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sad_tab_helper.cc

Issue 9733023: Fix crash in TabContentsViewViews::Focus. This was caused by r125126. The subtle bug is that the Sa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/sad_tab_helper.cc

===================================================================

--- chrome/browser/ui/sad_tab_helper.cc (revision 127433)

+++ chrome/browser/ui/sad_tab_helper.cc (working copy)

@@ -57,6 +57,10 @@

sad_tab_controller_mac::RemoveSadTab(sad_tab_.get());

#elif defined(TOOLKIT_VIEWS)

sad_tab_->Close();

+ // See http://crbug.com/117668. When the Widget is being destructed, we

+ // want calls to sad_tab() to return NULL.

+ scoped_ptr<views::Widget> local_sad_tab;

+ local_sad_tab.swap(sad_tab_);

#elif defined(TOOLKIT_GTK)

GtkWidget* expanded_container =

ChromeWebContentsViewDelegateGtk::GetFor(web_contents())->

« no previous file with comments | « no previous file | no next file » | no next file with comments »