Issue 9705098: Add Extension Keybinding test for page actions and port the PageAction keybindings to GTK (second a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9705098: Add Extension Keybinding test for page actions and port the PageAction keybindings to GTK (second a… (Closed)

Created:
8 years, 9 months ago by Finnur

Modified:
8 years, 9 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add Extension Keybinding test for page actions and port the PageAction keybindings to GTK (second attempt). Previous attempt failed because browser() was refactored out of the LocationBarView class before I had a chance to check in. Only changes from last changelist (https://chromiumcodereview.appspot.com/9693047) are in LocationBarView lines 1042-1044. BUG=27702 TEST=KeybindingApiTest.PageAction Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127156

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+215 lines, -15 lines)			Patch
M	chrome/browser/extensions/extension_keybinding_apitest.cc	View	5 chunks	+46 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.h	View	5 chunks	+37 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	9 chunks	+93 lines, -1 line	1 comment	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
A	chrome/test/data/extensions/api_test/keybinding/page_action/background.js	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/keybinding/page_action/manifest.json	View	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

8 years, 9 months ago (2012-03-16 13:13:08 UTC) #2

lgtm. relying on previous review for the most part.

https://chromiumcodereview.appspot.com/9705098/diff/1/chrome/browser/ui/gtk/l...
File chrome/browser/ui/gtk/location_bar_view_gtk.cc (right):

https://chromiumcodereview.appspot.com/9705098/diff/1/chrome/browser/ui/gtk/l...
chrome/browser/ui/gtk/location_bar_view_gtk.cc:1609: DCHECK(type ==
chrome::NOTIFICATION_WINDOW_CLOSED);
nit: DCHECK_EQ

Expand Messages | Collapse Messages