Add Extension Keybinding test for page actions. This is to facilitate an upcoming port of the PageA…

Add Extension Keybinding test for page actions and port the PageAction keybindings to GTK.

BUG=27702
TEST=KeybindingApiTest.PageAction
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127146

[Finnur, 2012-03-15 13:49:28]

Matt, can you review this CL?

Scott, can you give OWNERS approval for browser/ui.

https://chromiumcodereview.appspot.com/9693047/diff/7007/chrome/browser/ui/vi...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://chromiumcodereview.appspot.com/9693047/diff/7007/chrome/browser/ui/vi...
chrome/browser/ui/views/location_bar/location_bar_view.cc:1044: GURL url =
browser()->GetSelectedWebContents()->GetURL();
A note on this:

GetText() from model_ returns the current URL, but does so in a way that strips
http:// from it. This becomes a problem in the tests since the test URLs loaded
are...
GURL("http://127.0.0.1:20000/foo/bar.html") and stripped that becomes...
GURL("127.0.0.1:20000/foo/bar.html")
... which is not a URL that GURL can parse without assistance (thinks everything
in front of the colon is a scheme).

We could fix it with FixupURL but since we just want the actual URL we might as
well just call GetURL(), which returns the real thing.

I'll fix this in GTK when I port keybindings for page actions to GTK and
activate the test for GTK (I already verified it failed the same way there). I
need to see if Mac has the same problem (once keybindings are ported for Mac).

[Finnur, 2012-03-15 13:57:12]

Oh, and Elliot...
 
Can you review the GTK part (see also previous note about GetText() vs. GetURL()
in review comments).

[Finnur, 2012-03-15 13:59:58]

> I'll fix this in GTK when I port keybindings for page actions 
> to GTK and activate the test for GTK.

I realized I don't need to do this in two changelists; it is simpler to do this
in one pass so I combined both into one (this one). :)

[sky, 2012-03-15 16:55:36]

LGTM

[Elliot Glaysher, 2012-03-15 17:20:13]

lgtm

[Matt Perry, 2012-03-15 19:31:24]

lgtm, though I'll leave it up to erg to really review the gtk bits.

https://chromiumcodereview.appspot.com/9693047/diff/6003/chrome/browser/ui/gt...
File chrome/browser/ui/gtk/location_bar_view_gtk.cc (right):

https://chromiumcodereview.appspot.com/9693047/diff/6003/chrome/browser/ui/gt...
chrome/browser/ui/gtk/location_bar_view_gtk.cc:1629:
GetExtensionService()->GetExtensionById(page_action_->extension_id(),
Use extensions()->GetByID() instead. We're trying to move away from this method.

https://chromiumcodereview.appspot.com/9693047/diff/6003/chrome/browser/ui/gt...
chrome/browser/ui/gtk/location_bar_view_gtk.cc:1655:
keybinding_.get()->gdk_modifier_type(),
nit: can skip the .get()