Add Extension Keybinding test for page actions and port the PageAction keybindings to GTK (second a…

chrome/browser/ui/gtk/location_bar_view_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 20 matching lines @@
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_service.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_content_setting_bubble_model_delegate.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
 #include "chrome/browser/ui/content_settings/content_setting_image_model.h"
 #include "chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h"
 #include "chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.h"
+#include "chrome/browser/ui/gtk/browser_window_gtk.h"
 #include "chrome/browser/ui/gtk/content_setting_bubble_gtk.h"
 #include "chrome/browser/ui/gtk/extensions/extension_popup_gtk.h"
 #include "chrome/browser/ui/gtk/first_run_bubble.h"
 #include "chrome/browser/ui/gtk/gtk_util.h"
 #include "chrome/browser/ui/gtk/nine_box.h"
 #include "chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h"
 #include "chrome/browser/ui/gtk/rounded_window.h"
 #include "chrome/browser/ui/gtk/theme_service_gtk.h"
 #include "chrome/browser/ui/gtk/view_id_util.h"
 #include "chrome/browser/ui/omnibox/location_bar_util.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_action.h"
 #include "chrome/common/extensions/extension_resource.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "grit/theme_resources_standard.h"
 #include "net/base/net_util.h"
+#include "ui/base/accelerators/accelerator_gtk.h"
 #include "ui/base/dragdrop/gtk_dnd_util.h"
 #include "ui/base/gtk/gtk_hig_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas_skia_paint.h"
 #include "ui/gfx/font.h"
 #include "ui/gfx/gtk_util.h"
 #include "ui/gfx/image/image.h"
 #include "webkit/glue/window_open_disposition.h"
 
@@ skipping 591 matching lines @@
                        page_action_views_[i]->widget(), FALSE, FALSE, 0);
     }
     content::NotificationService::current()->Notify(
         chrome::NOTIFICATION_EXTENSION_PAGE_ACTION_COUNT_CHANGED,
         content::Source<LocationBar>(this),
         content::NotificationService::NoDetails());
   }
 
   WebContents* contents = GetWebContents();
   if (!page_action_views_.empty() && contents) {
-    GURL url = GURL(toolbar_model_->GetText());
+    GURL url = browser()->GetSelectedWebContents()->GetURL();
 
     for (size_t i = 0; i < page_action_views_.size(); i++) {
       page_action_views_[i]->UpdateVisibility(
           toolbar_model_->input_in_progress() ? NULL : contents, url);
     }
   }
 
   // If there are no visible page actions, hide the hbox too, so that it does
   // not affect the padding in the location bar.
   gtk_widget_set_visible(page_action_hbox_.get(),
@@ skipping 743 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 // LocationBarViewGtk::PageActionViewGtk
 
 LocationBarViewGtk::PageActionViewGtk::PageActionViewGtk(
     LocationBarViewGtk* owner,
     ExtensionAction* page_action)
     : owner_(NULL),
       page_action_(page_action),
       last_icon_pixbuf_(NULL),
       tracker_(this),
+      current_tab_id_(-1),
+      window_(NULL),
+      accel_group_(NULL),
       preview_enabled_(false) {
   event_box_.Own(gtk_event_box_new());
   gtk_widget_set_size_request(event_box_.get(),
                               Extension::kPageActionIconMaxSize,
                               Extension::kPageActionIconMaxSize);
 
   // Make the event box not visible so it does not paint a background.
   gtk_event_box_set_visible_window(GTK_EVENT_BOX(event_box_.get()), FALSE);
   g_signal_connect(event_box_.get(), "button-press-event",
                    G_CALLBACK(&OnButtonPressedThunk), this);
   g_signal_connect_after(event_box_.get(), "expose-event",
                          G_CALLBACK(OnExposeEventThunk), this);
+  g_signal_connect(event_box_.get(), "realize",
+                   G_CALLBACK(OnRealizeThunk), this);
 
   image_.Own(gtk_image_new());
   gtk_container_add(GTK_CONTAINER(event_box_.get()), image_.get());
 
   const Extension* extension = owner->browser()->profile()->
       GetExtensionService()->GetExtensionById(page_action->extension_id(),
                                               false);
   DCHECK(extension);
 
   // Load all the icons declared in the manifest. This is the contents of the
   // icons array, plus the default_icon property, if any.
   std::vector<std::string> icon_paths(*page_action->icon_paths());
   if (!page_action_->default_icon_path().empty())
     icon_paths.push_back(page_action_->default_icon_path());
 
   for (std::vector<std::string>::iterator iter = icon_paths.begin();
        iter != icon_paths.end(); ++iter) {
     tracker_.LoadImage(extension, extension->GetResource(*iter),
                        gfx::Size(Extension::kPageActionIconMaxSize,
                                  Extension::kPageActionIconMaxSize),
                        ImageLoadingTracker::DONT_CACHE);
   }
 
   // We set the owner last of all so that we can determine whether we are in
   // the process of initializing this class or not.
   owner_ = owner;
 }
 
 LocationBarViewGtk::PageActionViewGtk::~PageActionViewGtk() {
+  DisconnectPageActionAccelerator();
+
   image_.Destroy();
   event_box_.Destroy();
   for (PixbufMap::iterator iter = pixbufs_.begin(); iter != pixbufs_.end();
        ++iter) {
     g_object_unref(iter->second);
   }
   if (last_icon_pixbuf_)
     g_object_unref(last_icon_pixbuf_);
 }
 
@@ skipping 96 matching lines @@
   if (owner_)
     owner_->UpdatePageActions();
 }
 
 void LocationBarViewGtk::PageActionViewGtk::TestActivatePageAction() {
   GdkEventButton event = {};
   event.button = 1;
   OnButtonPressed(widget(), &event);
 }
 
+void LocationBarViewGtk::PageActionViewGtk::Observe(
+    int type,
+    const content::NotificationSource& source,
+    const content::NotificationDetails& details) {
+  DCHECK(type == chrome::NOTIFICATION_WINDOW_CLOSED);

[tommi (sloooow) - chröme, 2012/03/16 13:13:08]

nit: DCHECK_EQ

+  DisconnectPageActionAccelerator();
+}
+
 void LocationBarViewGtk::PageActionViewGtk::InspectPopup(
     ExtensionAction* action) {
   ShowPopup(true);
 }
 
 bool LocationBarViewGtk::PageActionViewGtk::ShowPopup(bool devtools) {
   if (!page_action_->HasPopup(current_tab_id_))
     return false;
 
   ExtensionPopupGtk::Show(
       page_action_->GetPopupUrl(current_tab_id_),
       owner_->browser_,
       event_box_.get(),
       devtools);
   return true;
 }
 
+void LocationBarViewGtk::PageActionViewGtk::ConnectPageActionAccelerator() {
+  const ExtensionSet* extensions = owner_->browser()->profile()->
+      GetExtensionService()->extensions();
+  const Extension* extension =
+      extensions->GetByID(page_action_->extension_id());
+  window_ = owner_->browser()->window()->GetNativeHandle();
+
+  // Iterate through all the keybindings and see if one is assigned to the
+  // pageAction.
+  const std::vector<Extension::ExtensionKeybinding>& commands =
+      extension->keybindings();
+  for (size_t i = 0; i < commands.size(); ++i) {
+    if (commands[i].command_name() !=
+        extension_manifest_values::kPageActionKeybindingEvent)
+      continue;
+
+    // Found the browser action shortcut command, register it.
+    keybinding_.reset(new ui::AcceleratorGtk(
+        commands[i].accelerator().key_code(),
+        commands[i].accelerator().IsShiftDown(),
+        commands[i].accelerator().IsCtrlDown(),
+        commands[i].accelerator().IsAltDown()));
+
+    accel_group_ = gtk_accel_group_new();
+    gtk_window_add_accel_group(window_, accel_group_);
+
+    gtk_accel_group_connect(
+        accel_group_,
+        keybinding_->GetGdkKeyCode(),
+        keybinding_->gdk_modifier_type(),
+        GtkAccelFlags(0),
+        g_cclosure_new(G_CALLBACK(OnGtkAccelerator), this, NULL));
+
+    // Since we've added an accelerator, we'll need to unregister it before
+    // the window is closed, so we listen for the window being closed.
+    registrar_.Add(this,
+                   chrome::NOTIFICATION_WINDOW_CLOSED,
+                   content::Source<GtkWindow>(window_));
+    break;
+  }
+}
+
+void LocationBarViewGtk::PageActionViewGtk::DisconnectPageActionAccelerator() {
+  if (accel_group_) {
+    gtk_accel_group_disconnect_key(
+        accel_group_,
+        keybinding_.get()->GetGdkKeyCode(),
+        static_cast<GdkModifierType>(keybinding_.get()->modifiers()));
+    gtk_window_remove_accel_group(window_, accel_group_);
+    g_object_unref(accel_group_);
+    accel_group_ = NULL;
+    keybinding_.reset(NULL);
+  }
+}
+
 gboolean LocationBarViewGtk::PageActionViewGtk::OnButtonPressed(
     GtkWidget* sender,
     GdkEventButton* event) {
   Profile* profile = owner_->browser()->profile();
   if (event->button != 3) {
     if (!ShowPopup(false)) {
       ExtensionService* service = profile->GetExtensionService();
       service->browser_event_router()->PageActionExecuted(profile,
           page_action_->extension_id(), page_action_->id(), current_tab_id_,
           current_url_.spec(), event->button);
@@ skipping 29 matching lines @@
   std::string badge_text = page_action_->GetBadgeText(tab_id);
   if (badge_text.empty())
     return FALSE;
 
   gfx::CanvasSkiaPaint canvas(event, false);
   GtkAllocation allocation;
   gtk_widget_get_allocation(widget, &allocation);
   page_action_->PaintBadge(&canvas, gfx::Rect(allocation), tab_id);
   return FALSE;
 }
+
+void LocationBarViewGtk::PageActionViewGtk::OnRealize(GtkWidget* widget) {
+  ConnectPageActionAccelerator();
+}
+
+// static
+gboolean LocationBarViewGtk::PageActionViewGtk::OnGtkAccelerator(
+    GtkAccelGroup* accel_group,
+    GObject* acceleratable,
+    guint keyval,
+    GdkModifierType modifier,
+    void* user_data) {
+  PageActionViewGtk* view = static_cast<PageActionViewGtk*>(user_data);
+  if (!gtk_widget_get_visible(view->widget()))
+    return FALSE;
+
+  GdkEventButton event = {};
+  event.button = 1;
+  return view->OnButtonPressed(view->widget(), &event);
+}