Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 9703089: Emit brief command strings for pexe translation. (Closed)

Created:
8 years, 9 months ago by Derek Schuff
Modified:
8 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Emit brief command strings for pexe translation. Also fixes the strip command to do the same. R=ncbray@google.com,mseaborn@chromium.org BUG= TEST= Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8041

Patch Set 1 #

Total comments: 1

Patch Set 2 : working #

Total comments: 1

Patch Set 3 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M SConstruct View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M site_scons/site_tools/component_setup.py View 1 chunk +1 line, -0 lines 0 comments Download
M site_scons/site_tools/naclsdk.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
(google.com) Derek Schuff
any ideas why it might not be working?
8 years, 9 months ago (2012-03-15 22:12:48 UTC) #1
robertm
one nit regarding your question, you could check whether the "Action()" stuff cause the problem ...
8 years, 9 months ago (2012-03-15 22:25:49 UTC) #2
(google.com) Derek Schuff
OK, PTAL. With this fix, both strip and translate now do the right thing in ...
8 years, 9 months ago (2012-03-15 22:45:05 UTC) #3
robertm
8 years, 9 months ago (2012-03-15 22:58:47 UTC) #4
LGTM

one nit

https://chromiumcodereview.appspot.com/9703089/diff/2002/SConstruct
File SConstruct (right):

https://chromiumcodereview.appspot.com/9703089/diff/2002/SConstruct#newcode1971
SConstruct:1971: trans_cmd = ('${TRANSLATECOM} ${SOURCES} -o ${TARGET}')
the "${SOURCES} -o ${TARGET}" part
could me moved into TRANSLATECOM 

we do this for almost all other xxxCOM
not sure why STRIPCOM is special.

Powered by Google App Engine
This is Rietveld 408576698