Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: SConstruct

Issue 9703089: Emit brief command strings for pexe translation. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: review comment Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | site_scons/site_tools/component_setup.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: SConstruct
diff --git a/SConstruct b/SConstruct
index 4a351324f10f6d1ceb9166219924942dcb270106..51a62a96fff9b2a50b7d31843a51d72e932f5a7b 100755
--- a/SConstruct
+++ b/SConstruct
@@ -1968,9 +1968,9 @@ DeclareBit('tests_use_irt', 'Non-browser tests also load the IRT image', False)
def GetTranslatedNexe(env, pexe):
pexe_name = pexe.abspath
nexe_name = pexe_name[:pexe_name.index('.pexe')] + '.nexe'
- trans_cmd = ('${TRANSLATE} ${TRANSLATEFLAGS} -Wl,-L${LIB_DIR} %s -o %s' %
- (pexe_name, nexe_name))
- return env.Command(nexe_name, pexe_name, trans_cmd)
+
+ return env.Command(target=nexe_name, source=[pexe_name],
+ action=[Action('${TRANSLATECOM}', '${TRANSLATECOMSTR}')])
pre_base_env.AddMethod(GetTranslatedNexe)
@@ -2258,7 +2258,7 @@ def StripExecutable(env, name, exe):
return env.Command(
target=name,
source=[exe],
- action=[Action('${STRIPCOM} ${SOURCES} -o ${TARGET}')])
+ action=[Action('${STRIPCOM} ${SOURCES} -o ${TARGET}', '${STRIPCOMSTR}')])
pre_base_env.AddMethod(StripExecutable)
« no previous file with comments | « no previous file | site_scons/site_tools/component_setup.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698