Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 9689040: Add placeholder translations for ash_strings (Closed)

Created:
8 years, 9 months ago by Zachary Kuznia
Modified:
8 years, 9 months ago
Reviewers:
tony
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add placeholder translations for ash_strings TBR=sky@chromium.org BUG=chromium-os:25682 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126326

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove launchpad translations #

Patch Set 3 : TBR sky@chromium.org #

Patch Set 4 : TBR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -2 lines) Patch
M ash/ash_strings.grd View 1 1 chunk +53 lines, -2 lines 0 comments Download
A ash/strings/ash_strings_am.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_ar.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_bg.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_bn.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_ca.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_cs.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_da.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_de.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_el.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_en-GB.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_es.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_es-419.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_et.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_fa.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_fi.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_fil.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_fr.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_gu.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_hi.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_hr.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_hu.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_id.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_it.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_iw.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_ja.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_kn.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_ko.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_lt.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_lv.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_ml.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_mr.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_ms.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_nl.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_no.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_pl.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_pt-BR.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_pt-PT.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_ro.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_ru.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_sk.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_sl.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_sr.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_sv.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_sw.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_ta.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_te.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_th.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_tr.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_uk.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_vi.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_zh-CN.xtb View 1 chunk +4 lines, -0 lines 0 comments Download
A ash/strings/ash_strings_zh-TW.xtb View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Zachary Kuznia
Hi tony, Could you review this at: https://chromiumcodereview.appspot.com/9689040 Should the placeholder files be added for ...
8 years, 9 months ago (2012-03-12 23:45:27 UTC) #1
tony
https://chromiumcodereview.appspot.com/9689040/diff/1/ash/ash_strings.grd File ash/ash_strings.grd (right): https://chromiumcodereview.appspot.com/9689040/diff/1/ash/ash_strings.grd#newcode108 ash/ash_strings.grd:108: <file path="../../../third_party/launchpad_translations/ash_strings_ast.xtb" lang="strings/ast" /> You can remove all the ...
8 years, 9 months ago (2012-03-12 23:51:53 UTC) #2
Zachary Kuznia
Launchpad removed. On 2012/03/12 23:51:53, tony wrote: > https://chromiumcodereview.appspot.com/9689040/diff/1/ash/ash_strings.grd > File ash/ash_strings.grd (right): > > ...
8 years, 9 months ago (2012-03-13 00:00:45 UTC) #3
tony
LGTM, thanks!
8 years, 9 months ago (2012-03-13 00:01:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/9689040/1068
8 years, 9 months ago (2012-03-13 01:29:17 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 03:42:12 UTC) #6
Change committed as 126326

Powered by Google App Engine
This is Rietveld 408576698