Issue 9653022: Revert 125811 - Convert app_bindings.js to the schema_generated_bindings.js infrastructure.

Issue 9653022: Revert 125811 - Convert app_bindings.js to the schema_generated_bindings.js infrastructure. (Closed)

Created:
8 years, 9 months ago by akalin

Modified:
8 years, 9 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 125811 - Convert app_bindings.js to the schema_generated_bindings.js infrastructure. This involves opening up *all* custom bindings to web pages, where access is controlled content-script style using a URL-matches property in the API schema. BUG=104100, 117282 TEST=unit_tests,browser_tests Review URL: http://codereview.chromium.org/9460002 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125813

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+333 lines, -561 lines)			Patch
M	chrome/browser/renderer_host/chrome_render_view_host_observer.cc	View	2 chunks	+8 lines, -15 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/common_resources.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/common/extensions/api/app.json	View	1 chunk	+0 lines, -70 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.h	View	6 chunks	+33 lines, -35 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	5 chunks	+55 lines, -112 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api_unittest.cc	View	4 chunks	+29 lines, -115 lines	0 comments	Download
M	chrome/common/extensions/extension_messages.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_permission_set.h	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/extension_permission_set.cc	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/common/extensions/feature.h	View	1 chunk	+3 lines, -13 lines	0 comments	Download
M	chrome/common/extensions/feature.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/feature_unittest.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/renderer/extensions/app_bindings.cc	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/chrome_v8_context.h	View	4 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_v8_context.cc	View	3 chunks	+5 lines, -9 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_v8_context_set_unittest.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
A +	chrome/renderer/extensions/custom_bindings_util.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/renderer/extensions/custom_bindings_util.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/renderer/extensions/extension_custom_bindings.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.h	View	5 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.cc	View	13 chunks	+118 lines, -49 lines	0 comments	Download
M	chrome/renderer/extensions/schema_generated_bindings.cc	View	2 chunks	+16 lines, -19 lines	0 comments	Download
M	chrome/renderer/renderer_resources.grd	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/resource_bundle_source_map.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/renderer/resources/extensions/app.js	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/renderer/resources/extensions/app_custom_bindings.js	View	1 chunk	+0 lines, -56 lines	0 comments	Download
M	chrome/renderer/resources/extensions/setup_bindings.js	View	1 chunk	+13 lines, -9 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/content_scripts/extension_iframe/iframe.js	View	1 chunk	+4 lines, -8 lines	0 comments	Download
MM	chrome/test/data/extensions/api_test/stubs/content_script.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages