chrome/common/extensions/feature_unittest.cc - Issue 9653022: Revert 125811 - Convert app_bindings.js to the schema_generated_bindings.js infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/feature_unittest.cc

Issue 9653022: Revert 125811 - Convert app_bindings.js to the schema_generated_bindings.js infrastructure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/feature_unittest.cc

===================================================================

--- chrome/common/extensions/feature_unittest.cc (revision 125812)

+++ chrome/common/extensions/feature_unittest.cc (working copy)

@@ -220,14 +220,12 @@

contexts->Append(Value::CreateStringValue("privileged"));

contexts->Append(Value::CreateStringValue("unprivileged"));

contexts->Append(Value::CreateStringValue("content_script"));

- contexts->Append(Value::CreateStringValue("web_page"));

value->Set("contexts", contexts);

scoped_ptr<Feature> feature(Feature::Parse(value.get()));

- EXPECT_EQ(4u, feature->contexts()->size());

+ EXPECT_EQ(3u, feature->contexts()->size());

EXPECT_TRUE(feature->contexts()->count(Feature::PRIVILEGED_CONTEXT));

EXPECT_TRUE(feature->contexts()->count(Feature::UNPRIVILEGED_CONTEXT));

EXPECT_TRUE(feature->contexts()->count(Feature::CONTENT_SCRIPT_CONTEXT));

- EXPECT_TRUE(feature->contexts()->count(Feature::WEB_PAGE_CONTEXT));

value->SetString("contexts", "all");

scoped_ptr<Feature> feature2(Feature::Parse(value.get()));

« no previous file with comments | « chrome/common/extensions/feature.cc ('k') | chrome/renderer/extensions/app_bindings.cc » ('j') | no next file with comments »