Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 959003005: Use goma by default on Windows. (Closed)

Created:
5 years, 9 months ago by shinyak
Modified:
4 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

(abandonded) Use goma by default on Windows. We've set NO_NACL_GOMA=false on Windows buildbot, and it looks working well. Let's use goma by default even on Windows. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/build_nexe.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
shinyak
Hi, I've enabled goma on buildbots. But I'd also like to enable user environment. So, ...
5 years, 9 months ago (2015-03-05 04:06:22 UTC) #2
Yoshisato Yanagisawa
lgtm. I really appreciate your hard work to fix the issue.
5 years, 9 months ago (2015-03-05 04:14:56 UTC) #3
bradn
LGTM Thanks!
5 years, 9 months ago (2015-03-05 18:03:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959003005/1
5 years, 9 months ago (2015-03-06 02:07:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: nacl-win8-64_newlib_dbg on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-win8-64_newlib_dbg/builds/3266)
5 years, 9 months ago (2015-03-06 03:54:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959003005/1
5 years, 9 months ago (2015-03-06 05:08:15 UTC) #11
shinyak
mmm... try again.
5 years, 9 months ago (2015-03-06 05:08:15 UTC) #12
shinyak
5 years, 9 months ago (2015-03-06 05:27:42 UTC) #14
unchecked because the previous fix is in reverting.

Powered by Google App Engine
This is Rietveld 408576698