build/build_nexe.py - Issue 959003005: Use goma by default on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/build_nexe.py

Issue 959003005: Use goma by default on Windows. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/build_nexe.py

diff --git a/build/build_nexe.py b/build/build_nexe.py

index 2afb6a0e16b3c9b6a11fa98a755a3bfe59aad6c0..0d7c83f4f899bbf9bb0af1a5f9a153a99d058d98 100644

--- a/build/build_nexe.py

+++ b/build/build_nexe.py

@@ -404,7 +404,7 @@ class Builder(CommandRunner):

# Start goma support from os/arch/toolname that have been tested.

# Set NO_NACL_GOMA=true to force to avoid using goma.

- default_no_nacl_goma = True if pynacl.platform.IsWindows() else False

+ default_no_nacl_goma = False

if (arch not in ['x86-32', 'x86-64', 'pnacl']

or toolname not in ['newlib', 'glibc']

or IsEnvFlagTrue('NO_NACL_GOMA', default=default_no_nacl_goma)

« no previous file with comments | « no previous file | no next file » | no next file with comments »