Issue 9533015: Revert 119423 - Revert 119306 - Turn web intents build flag on.

Issue 9533015: Revert 119423 - Revert 119306 - Turn web intents build flag on. (Closed)

Created:
8 years, 9 months ago by Greg Billock

Modified:
8 years, 9 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, arv (Not doing code reviews), darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1025/src/

Visibility:
Public.

More Reviews

Description

Revert 119423 - Revert 119306 - Turn web intents build flag on. Move the command-line flag to default-on. (Revert of 119284 : https://chromiumcodereview.appspot.com/9212036) IN CASE OF FIRE, PULL THIS HANDLE! If web intents needs to be disabled, revert this change. R=jhawkins@chromium.org BUG=111135 TEST=None Review URL: http://codereview.chromium.org/9271084 TBR=gbillock@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124228

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -50 lines)			Patch
M	build/common.gypi	View	3 chunks	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/content_settings/host_content_settings_map.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/options.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/options_bundle.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options2/content_settings.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options2/options.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options2/options_bundle.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/content_settings_handler.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/content_settings_handler2.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension_manifests_unittest.cc	View	2 chunks	+16 lines, -10 lines	0 comments	Download
M	content/browser/intents/intent_injector.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Greg Billock

8 years, 9 months ago (2012-02-29 19:36:18 UTC) #2

(Note mostly to self: this reversion was with drover, re-disabling the
web intents flag for M18 stable.)

# disable web intents flag m18

On Wed, Feb 29, 2012 at 11:28 AM,  <gbillock@chromium.org> wrote:
> Reviewers: Greg Billock,
>
> Description:
> Revert 119423 - Revert 119306 - Turn web intents build flag on.
>
> Move the command-line flag to default-on.
>
> (Revert of 119284 : https://chromiumcodereview.appspot.com/9212036)
>
> IN CASE OF FIRE, PULL THIS HANDLE! If web intents needs
> to be disabled, revert this change.
>
> R=jhawkins@chromium.org
> BUG=111135
> TEST=None
>
>
> Review URL: http://codereview.chromium.org/9271084
>
> TBR=gbillock@chromium.org
>
> Please review this at https://chromiumcodereview.appspot.com/9533015/
>
> SVN Base: svn://svn.chromium.org/chrome/branches/1025/src/
>
> Affected files:
>  M     build/common.gypi
>  M     chrome/browser/content_settings/host_content_settings_map.cc
>  M     chrome/browser/resources/options/options.html
>  M     chrome/browser/resources/options/options_bundle.js
>  M     chrome/browser/resources/options2/content_settings.html
>  M     chrome/browser/resources/options2/options.html
>  M     chrome/browser/resources/options2/options_bundle.js
>  M     chrome/browser/ui/browser.cc
>  M     chrome/browser/ui/webui/options/content_settings_handler.cc
>  M     chrome/browser/ui/webui/options2/content_settings_handler2.cc
>  M     chrome/common/extensions/extension.cc
>  M     chrome/common/extensions/extension_manifests_unittest.cc
>  M     content/browser/intents/intent_injector.cc
>  M     content/public/common/content_switches.h
>  M     content/public/common/content_switches.cc
>
>

Expand Messages | Collapse Messages