Turn web intents build flag on. Move the command-line flag to default on.

Turn web intents build flag on. Move the command-line flag to default on.

Make the flag disable rather than enable web intents.
Put the options UI behind a new flag controlling functionality if the registration tag is present for web content.

IN CASE OF FIRE, PULL THIS HANDLE! If web intents needs
to be disabled, revert this change.

R=jhawkins@chromium.org
BUG=90458
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119284

[James Hawkins, 2012-01-24 00:26:55]

LGTM. Ship it.

[commit-bot: I haz the power, 2012-01-24 00:55:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/9212036/1

[commit-bot: I haz the power, 2012-01-24 00:55:31]

Presubmit check for 9212036-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/public/common/content_switches.cc,content/public/common/content_switches.h,chrome/browser/ui/browser.cc

Presubmit checks took 1.6s to calculate.

[Greg Billock, 2012-01-24 01:07:08]

Peter, John, can I get owners approval? Thanks.

On 2012/01/24 00:55:31, I haz the power (commit-bot) wrote:
> Presubmit check for 9212036-1 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for:
>
content/public/common/content_switches.cc,content/public/common/content_switches.h,chrome/browser/ui/browser.cc
> 
> Presubmit checks took 1.6s to calculate.

[jam, 2012-01-24 01:13:49]

content/public lgtm

[sky, 2012-01-24 01:21:52]

chrome/browser/ui LGTM

[commit-bot: I haz the power, 2012-01-24 01:24:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/9212036/1

[commit-bot: I haz the power, 2012-01-24 02:15:27]

Try job failure for 9212036-1 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-01-24 18:02:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/9212036/1

[commit-bot: I haz the power, 2012-01-24 18:46:03]

Try job failure for 9212036-1 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Aaron Boodman, 2012-01-24 23:30:14]

The intents key is currently enabled for hosted apps, packaged apps, and
extensions. Is this what you want? Hosted apps are really just web pages and
usually have a small subset of the permissions available to extensions or
packaged apps.

[James Hawkins, 2012-01-24 23:34:49]

On 2012/01/24 23:30:14, Aaron Boodman wrote:
> The intents key is currently enabled for hosted apps, packaged apps, and
> extensions. Is this what you want? Hosted apps are really just web pages and
> usually have a small subset of the permissions available to extensions or
> packaged apps.

Yes, this is what we want.  Ideally we'd have Intents available for regular
non-hosted web pages as well, but that is blocked by a debate over the
registration mechanism in WhatWG.

[Greg Billock, 2012-01-25 00:05:16]

James, instead of deleting the options UI framework outright, I've put it behind
a default-off gyp flag that we can enable once we get the mechanism for web
content registration for intents checked in.

On 2012/01/24 23:34:49, James Hawkins wrote:
> On 2012/01/24 23:30:14, Aaron Boodman wrote:
> > The intents key is currently enabled for hosted apps, packaged apps, and
> > extensions. Is this what you want? Hosted apps are really just web pages and
> > usually have a small subset of the permissions available to extensions or
> > packaged apps.
> 
> Yes, this is what we want.  Ideally we'd have Intents available for regular
> non-hosted web pages as well, but that is blocked by a debate over the
> registration mechanism in WhatWG.

[commit-bot: I haz the power, 2012-01-25 17:01:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/9212036/9001

[commit-bot: I haz the power, 2012-01-25 17:54:52]

Try job failure for 9212036-9001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[James Hawkins, 2012-01-26 02:03:40]

What's going on with this CL?  Are we waiting on a WK roll?  We need to get it
in ASAP.

[Greg Billock, 2012-01-26 03:04:38]

On 2012/01/26 02:03:40, James Hawkins wrote:
> What's going on with this CL?  Are we waiting on a WK roll?  We need to get it
> in ASAP.

The windows compile error in the webkit code is the problem. I think Arthur and
I have it figured out, but that's the hang-up. I thought the previous change did
the trick, but there was another problem hiding behind that one.

[commit-bot: I haz the power, 2012-01-26 19:48:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/9212036/11007