Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 9533015: Revert 119423 - Revert 119306 - Turn web intents build flag on. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1025/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | content/browser/intents/intent_injector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_manifests_unittest.cc
===================================================================
--- chrome/common/extensions/extension_manifests_unittest.cc (revision 124226)
+++ chrome/common/extensions/extension_manifests_unittest.cc (working copy)
@@ -775,17 +775,21 @@
}
TEST_F(ExtensionManifestTest, WebIntents) {
- Testcase testcases[] = {
- {"intent_invalid_1.json", errors::kInvalidIntents},
- {"intent_invalid_2.json", errors::kInvalidIntent},
- {"intent_invalid_3.json", errors::kInvalidIntentPath},
- {"intent_invalid_4.json", errors::kInvalidIntentDisposition},
- {"intent_invalid_5.json", errors::kInvalidIntentType},
- {"intent_invalid_6.json", errors::kInvalidIntentTitle},
- {"intent_invalid_packaged_app.json", errors::kCannotAccessPage}
- };
- RunTestcases(testcases, arraysize(testcases));
+ CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnableWebIntents);
+ LoadAndExpectError("intent_invalid_1.json",
+ extension_manifest_errors::kInvalidIntents);
+ LoadAndExpectError("intent_invalid_2.json",
+ extension_manifest_errors::kInvalidIntent);
+ LoadAndExpectError("intent_invalid_3.json",
+ extension_manifest_errors::kInvalidIntentPath);
+ LoadAndExpectError("intent_invalid_4.json",
+ extension_manifest_errors::kInvalidIntentDisposition);
+ LoadAndExpectError("intent_invalid_5.json",
+ extension_manifest_errors::kInvalidIntentType);
+ LoadAndExpectError("intent_invalid_6.json",
+ extension_manifest_errors::kInvalidIntentTitle);
+
scoped_refptr<Extension> extension(
LoadAndExpectSuccess("intent_valid.json"));
ASSERT_TRUE(extension.get() != NULL);
@@ -818,6 +822,8 @@
}
TEST_F(ExtensionManifestTest, WebIntentsWithMultipleMimeTypes) {
+ CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnableWebIntents);
+
scoped_refptr<Extension> extension(
LoadAndExpectSuccess("intent_valid_multitype.json"));
ASSERT_TRUE(extension.get() != NULL);
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | content/browser/intents/intent_injector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698