Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2918)

Issue 9533003: libjpeg_turbo: Filter out "section flags ignored on section redeclaration" warnings on mac. (Closed)

Created:
7 years, 6 months ago by Nico
Modified:
7 years, 6 months ago
Reviewers:
Hironori Bono
CC:
chromium-reviews
Visibility:
Public.

Description

libjpeg_turbo: Filter out "section flags ignored on section redeclaration" warnings on mac. This removes over 50 lines of warning output when doing a clobber build on mac. Thanks to mark@ for telling me how to get >() process substitution work with gyp. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124240

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M libjpeg.gyp View 1 4 chunks +11 lines, -0 lines 0 comments Download
A yasm-filter.sh View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 6 months ago (2012-02-29 06:41:18 UTC) #1
Hironori Bono
LGTM. Thanks for your fix. (It may be better to fix 'jsimdext.inc'?) Regards, Hironori Bono
7 years, 6 months ago (2012-02-29 07:31:09 UTC) #2
Nico
Thank you for your review! On 2012/02/29 07:31:09, Hironori Bono wrote: > (It may be ...
7 years, 6 months ago (2012-02-29 20:23:49 UTC) #3
Nico
7 years, 6 months ago (2012-02-29 20:33:16 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698