Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: libjpeg.gyp

Issue 9533003: libjpeg_turbo: Filter out "section flags ignored on section redeclaration" warnings on mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/libjpeg_turbo/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | yasm-filter.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libjpeg.gyp
===================================================================
--- libjpeg.gyp (revision 119959)
+++ libjpeg.gyp (working copy)
@@ -193,6 +193,7 @@
'-DMSVC',
'-Iwin/'
],
+ 'yasm_output_filter': [],
},
}],
[ 'OS=="mac"', {
@@ -206,6 +207,14 @@
'-DMACHO',
'-Imac/'
],
+ # On Mac, jsimdext.inc contains a "SECTION SEG_CONST". This file
+ # is included by all .asm file, and most files contain another
+ # "SECTION SEG_CONST". SEG_CONST is ".rodata align=16" on mac,
+ # which leads to
+ # "warning: section flags ignored on section redeclaration"
+ # warnings on all .asm files. This script filters out this
+ # warning.
+ 'yasm_output_filter': ['./yasm-filter.sh'],
},
}],
[ 'OS=="linux"', {
@@ -239,6 +248,7 @@
'-DELF',
'-Ilinux/'
],
+ 'yasm_output_filter': [],
}],
],
},
@@ -255,6 +265,7 @@
'<(shared_generated_dir)/<(RULE_INPUT_ROOT).<(object_suffix)',
],
'action': [
+ '<@(yasm_output_filter)',
'<(yasm_path)',
'<(yasm_format)',
'<@(yasm_flags)',
« no previous file with comments | « no previous file | yasm-filter.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698