Issue 9500008: Move font_list_async.h to content/public. Switch to Pass() goodness to simplify code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9500008: Move font_list_async.h to content/public. Switch to Pass() goodness to simplify code. (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move font_list_async.h to content/public. Switch to Pass() goodness to simplify code. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124224

Patch Set 1 #

Patch Set 2 : fix clang #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -112 lines)			Patch
M	chrome/browser/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/font_settings_handler.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/font_settings_handler.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/font_settings_handler2.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/font_settings_handler2.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
D	content/browser/font_list_async.h	View		1 chunk	+0 lines, -46 lines	0 comments	Download
M	content/browser/font_list_async.cc	View		2 chunks	+9 lines, -15 lines	0 comments	Download
M	content/browser/renderer_host/pepper_message_filter.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/pepper_message_filter.cc	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download
M	content/common/font_list.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	content/common/font_list_android.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/common/font_list_mac.mm	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/common/font_list_win.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/common/font_list_x11.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/content_browser.gypi	View		2 chunks	+1 line, -1 line	0 comments	Download
A +	content/public/browser/font_list_async.h	View		3 chunks	+4 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages