Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1904)

Unified Diff: content/common/font_list_win.cc

Issue 9500008: Move font_list_async.h to content/public. Switch to Pass() goodness to simplify code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix clang Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/font_list_mac.mm ('k') | content/common/font_list_x11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/font_list_win.cc
===================================================================
--- content/common/font_list_win.cc (revision 124079)
+++ content/common/font_list_win.cc (working copy)
@@ -29,7 +29,7 @@
return 1;
}
-ListValue* GetFontList_SlowBlocking() {
+scoped_ptr<ListValue> GetFontList_SlowBlocking() {
std::set<string16> font_names;
LOGFONTW logfont;
@@ -41,7 +41,7 @@
(LPARAM)&font_names, 0);
::ReleaseDC(NULL, hdc);
- ListValue* font_list = new ListValue;
+ scoped_ptr<ListValue> font_list(new ListValue);
std::set<string16>::iterator iter;
for (iter = font_names.begin(); iter != font_names.end(); iter++) {
ListValue* font_item = new ListValue();
@@ -49,7 +49,7 @@
font_item->Append(Value::CreateStringValue(*iter));
font_list->Append(font_item);
}
- return font_list;
+ return font_list.Pass();
}
} // namespace content
« no previous file with comments | « content/common/font_list_mac.mm ('k') | content/common/font_list_x11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698