Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: content/common/font_list_mac.mm

Issue 9500008: Move font_list_async.h to content/public. Switch to Pass() goodness to simplify code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix clang Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/font_list_android.cc ('k') | content/common/font_list_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/font_list_mac.mm
===================================================================
--- content/common/font_list_mac.mm (revision 124079)
+++ content/common/font_list_mac.mm (working copy)
@@ -12,9 +12,9 @@
namespace content {
-ListValue* GetFontList_SlowBlocking() {
+scoped_ptr<ListValue> GetFontList_SlowBlocking() {
base::mac::ScopedNSAutoreleasePool autorelease_pool;
- ListValue* font_list = new ListValue;
+ scoped_ptr<ListValue> font_list(new ListValue);
NSFontManager* fontManager = [[[NSFontManager alloc] init] autorelease];
NSArray* fonts = [fontManager availableFontFamilies];
for (NSString* family_name in fonts) {
@@ -27,7 +27,7 @@
font_item->Append(Value::CreateStringValue(loc_family));
font_list->Append(font_item);
}
- return font_list;
+ return font_list.Pass();
}
} // namespace content
« no previous file with comments | « content/common/font_list_android.cc ('k') | content/common/font_list_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698