|
Reduce flakiness in chrome_frame_tests.exe by having each test run in a clean environment.
This includes:
* A TestScrubber runs between all test to kill stray IE and Chrome processes and delete the user data dir.
* Refactored CFACWithChrome and ProxyFactoryTest tests to get rid of copy-n-paste.
* Tests in ChromeFrameTestWithWebServer that launch Chrome now use a fresh user data dir so as not to collide with a users' existing profile.
BUG= 81479, 114386
TEST=chrome_frame_tests.exe is green on the win_cf trybot
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123973
Total comments: 19
Total comments: 8
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+418 lines, -250 lines) |
Patch |
|
M |
chrome_frame/chrome_frame.gyp
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome_frame/test/automation_client_mock.cc
|
View
|
1
2
3
|
3 chunks |
+94 lines, -103 lines |
0 comments
|
Download
|
|
M |
chrome_frame/test/chrome_frame_automation_mock.h
|
View
|
|
3 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome_frame/test/chrome_frame_automation_mock.cc
|
View
|
|
2 chunks |
+2 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome_frame/test/chrome_frame_test_utils.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome_frame/test/chrome_frame_test_utils.cc
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome_frame/test/proxy_factory_mock.cc
|
View
|
|
3 chunks |
+59 lines, -60 lines |
0 comments
|
Download
|
|
M |
chrome_frame/test/run_all_unittests.cc
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome_frame/test/test_scrubber.h
|
View
|
1
2
3
|
1 chunk |
+36 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome_frame/test/test_scrubber.cc
|
View
|
1
2
3
4
|
1 chunk |
+146 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome_frame/test/test_with_web_server.h
|
View
|
|
5 chunks |
+19 lines, -27 lines |
0 comments
|
Download
|
|
M |
chrome_frame/test/test_with_web_server.cc
|
View
|
1
2
|
6 chunks |
+42 lines, -36 lines |
0 comments
|
Download
|
|
M |
chrome_frame/test/ui_test.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome_frame/test_utils.cc
|
View
|
|
2 chunks |
+2 lines, -11 lines |
0 comments
|
Download
|
Total messages: 6 (0 generated)
|