Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3206)

Unified Diff: chrome_frame/test/chrome_frame_test_utils.cc

Issue 9460019: Reduce flakiness in chrome_frame_tests.exe by having each run in a clean environment. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed compile break Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/chrome_frame_test_utils.h ('k') | chrome_frame/test/proxy_factory_mock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/chrome_frame_test_utils.cc
diff --git a/chrome_frame/test/chrome_frame_test_utils.cc b/chrome_frame/test/chrome_frame_test_utils.cc
index 7175eb8450c8f03b743a9a4cb298ea68c26929de..59b542a76e8738f296a5270525ed8ccd2781ba70 100644
--- a/chrome_frame/test/chrome_frame_test_utils.cc
+++ b/chrome_frame/test/chrome_frame_test_utils.cc
@@ -177,13 +177,16 @@ base::ProcessHandle LaunchExecutable(const std::wstring& executable,
return process;
}
-base::ProcessHandle LaunchChrome(const std::wstring& url) {
+base::ProcessHandle LaunchChrome(const std::wstring& url,
+ const FilePath& user_data_dir) {
FilePath path;
PathService::Get(base::DIR_MODULE, &path);
path = path.AppendASCII(kChromeImageName);
CommandLine cmd(path);
cmd.AppendSwitch(switches::kNoFirstRun);
+ if (!user_data_dir.empty())
+ cmd.AppendSwitchPath(switches::kUserDataDir, user_data_dir);
cmd.AppendArgNative(url);
base::ProcessHandle process = NULL;
« no previous file with comments | « chrome_frame/test/chrome_frame_test_utils.h ('k') | chrome_frame/test/proxy_factory_mock.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698