Issue 9406017: Flakiness cleanup: disable flaky tests under chrome/

Issue 9406017: Flakiness cleanup: disable flaky tests under chrome/ (Closed)

Created:
8 years, 10 months ago by Evan Martin

Modified:
8 years, 9 months ago

Reviewers:
tony, Peter Mayo

CC:
chromium-reviews, tfarina, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Flakiness cleanup: disable flaky tests under chrome/ BUG=84299, 99469, 90557, 109292, 38497, 45243, 84854, 59785, 59783, 59784, 100567, 62777, 60426 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122137

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -16 lines)			Patch
M	chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/view_id_util_browsertest.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/important_file_writer_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/logging_chrome_uitest.cc	View	2 chunks	+2 lines, -2 lines	2 comments	Download
M	chrome/common/service_process_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/copy_tree_work_item_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/installer/util/product_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/external_extension_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM https://chromiumcodereview.appspot.com/9406017/diff/1/chrome/common/logging_chrome_uitest.cc File chrome/common/logging_chrome_uitest.cc (right): https://chromiumcodereview.appspot.com/9406017/diff/1/chrome/common/logging_chrome_uitest.cc#newcode163 chrome/common/logging_chrome_uitest.cc:163: #define MAYBE_Crash DISABLED_Crash What is OS_CHROME? I bet ...

8 years, 10 months ago (2012-02-15 19:51:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9406017/1

8 years, 10 months ago (2012-02-15 19:56:55 UTC) #3

commit-bot: I haz the power

Presubmit check for 9406017-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 10 months ago (2012-02-15 19:57:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9406017/1

8 years, 10 months ago (2012-02-15 19:57:46 UTC) #5

Peter Mayo

8 years, 9 months ago (2012-03-02 04:59:30 UTC) #6

https://chromiumcodereview.appspot.com/9406017/diff/1/chrome/common/logging_c...
File chrome/common/logging_chrome_uitest.cc (right):

https://chromiumcodereview.appspot.com/9406017/diff/1/chrome/common/logging_c...
chrome/common/logging_chrome_uitest.cc:163: #define MAYBE_Crash DISABLED_Crash
On 2012/02/15 19:51:50, tony wrote:
> What is OS_CHROME?  I bet this does nothing :(

As of build 6066 of an internal builder for chromeos, this test is now failing.

Expand Messages | Collapse Messages