chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm - Issue 9406017: Flakiness cleanup: disable flaky tests under chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm

Issue 9406017: Flakiness cleanup: disable flaky tests under chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm ('k') | chrome/browser/ui/cocoa/view_id_util_browsertest.mm » ('j') | chrome/common/logging_chrome_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm b/chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm

index 6d7f386e777c63c9c02844be02be4d4d48176250..d6911dd7e66884fa1276a23072c9ecc661cdb33c 100644

--- a/chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm

@@ -37,7 +37,7 @@ class AvatarButtonControllerTest : public CocoaProfileTest {

};

// Only fails on 10.5 for some reason <http://crbug.com/99469>.

-TEST_F(AvatarButtonControllerTest, FLAKY_AddRemoveProfiles) {

+TEST_F(AvatarButtonControllerTest, DISABLED_AddRemoveProfiles) {

EXPECT_TRUE([button() isHidden]);

testing_profile_manager()->CreateTestingProfile("one");

@@ -55,7 +55,7 @@ TEST_F(AvatarButtonControllerTest, FLAKY_AddRemoveProfiles) {

}

// Only fails on 10.5 for some reason <http://crbug.com/99469>.

-TEST_F(AvatarButtonControllerTest, FLAKY_DoubleOpen) {

+TEST_F(AvatarButtonControllerTest, DISABLED_DoubleOpen) {

EXPECT_FALSE([controller() menuController]);

[button() performClick:button()];