Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7655)

Unified Diff: chrome/common/logging_chrome_uitest.cc

Issue 9406017: Flakiness cleanup: disable flaky tests under chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/important_file_writer_unittest.cc ('k') | chrome/common/service_process_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome_uitest.cc
diff --git a/chrome/common/logging_chrome_uitest.cc b/chrome/common/logging_chrome_uitest.cc
index 6b26b70f235eb7b4777cf75e6b9483aaaf088d2b..f41f59aedcee8ac7264741ca6a407303e0cd59a4 100644
--- a/chrome/common/logging_chrome_uitest.cc
+++ b/chrome/common/logging_chrome_uitest.cc
@@ -125,7 +125,7 @@ class CheckFalseTest : public UITest {
#if defined(OS_WIN)
// http://crbug.com/38497
-#define CheckFails FLAKY_CheckFails
+#define CheckFails DISABLED_CheckFails
#elif defined(OS_MACOSX)
// Crash service doesn't exist for the Mac yet: http://crbug.com/45243
#define CheckFails DISABLED_CheckFails
@@ -160,7 +160,7 @@ class RendererCrashTest : public UITest {
// Crash service doesn't exist for the Mac yet: http://crbug.com/45243
#define MAYBE_Crash DISABLED_Crash
#elif defined(OS_CHROME)
-#define MAYBE_Crash FLAKY_Crash
+#define MAYBE_Crash DISABLED_Crash
tony 2012/02/15 19:51:50 What is OS_CHROME? I bet this does nothing :(
Peter Mayo 2012/03/02 04:59:30 As of build 6066 of an internal builder for chrome
#else
#define MAYBE_Crash Crash
#endif
« no previous file with comments | « chrome/common/important_file_writer_unittest.cc ('k') | chrome/common/service_process_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698