Strip brackets from IPv6 host literals before passing down to PAC script.

Strip brackets from IPv6 host literals before passing down to PAC script.

BUG=113705
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121574

[mmenke, 2012-02-10 20:53:50]

LGTM

https://chromiumcodereview.appspot.com/9383010/diff/1/net/proxy/proxy_resolve...
File net/proxy/proxy_resolver_v8_unittest.cc (right):

https://chromiumcodereview.appspot.com/9383010/diff/1/net/proxy/proxy_resolve...
net/proxy/proxy_resolver_v8_unittest.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
nit:  Update date.

https://chromiumcodereview.appspot.com/9383010/diff/1/net/proxy/proxy_resolve...
net/proxy/proxy_resolver_v8_unittest.cc:559: CapturingBoundNetLog
log(CapturingNetLog::kUnbounded);
Doesn't seem to be any reason not to just use a BoundNetLog().

[eroman, 2012-02-10 21:03:53]

https://chromiumcodereview.appspot.com/9383010/diff/1/net/proxy/proxy_resolve...
File net/proxy/proxy_resolver_v8_unittest.cc (right):

https://chromiumcodereview.appspot.com/9383010/diff/1/net/proxy/proxy_resolve...
net/proxy/proxy_resolver_v8_unittest.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2012/02/10 20:53:50, Matt Menke wrote:
> nit:  Update date.

Done.

https://chromiumcodereview.appspot.com/9383010/diff/1/net/proxy/proxy_resolve...
net/proxy/proxy_resolver_v8_unittest.cc:559: CapturingBoundNetLog
log(CapturingNetLog::kUnbounded);
On 2012/02/10 20:53:50, Matt Menke wrote:
> Doesn't seem to be any reason not to just use a BoundNetLog().

Done. I had copy-pasted this without thinking :-)

[commit-bot: I haz the power, 2012-02-10 21:05:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/9383010/3001

[commit-bot: I haz the power, 2012-02-10 21:05:03]

Presubmit check for 9383010-3001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.( \*/)?\n
Found a bad license header in these files:
  net/data/proxy_resolver_v8_unittest/resolve_host.js

Presubmit checks took 1.5s to calculate.

[commit-bot: I haz the power, 2012-02-10 21:14:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/9383010/1004

[commit-bot: I haz the power, 2012-02-11 00:07:57]

Change committed as 121574