Strip brackets from IPv6 host literals before passing down to PAC script.

net/proxy/proxy_resolver_v8_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

[mmenke, 2012/02/10 20:53:50]

nit:  Update date.

[eroman, 2012/02/10 21:03:53]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "googleurl/src/gurl.h"
@@ skipping 527 matching lines @@
   // before passing it onto the bindings layer.
   MockJSBindings* bindings = resolver.mock_js_bindings();
 
   ASSERT_EQ(1u, bindings->dns_resolves.size());
   EXPECT_EQ("xn--bcher-kva.ch", bindings->dns_resolves[0]);
 
   ASSERT_EQ(1u, bindings->dns_resolves_ex.size());
   EXPECT_EQ("xn--bcher-kva.ch", bindings->dns_resolves_ex[0]);
 }
 
+// Test that when resolving a URL which contains an IPv6 string literal, the
+// brackets are removed from the host before passing it down to the PAC script.
+// If we don't do this, then subsequent calls to dnsResolveEx(host) will be
+// doomed to fail since it won't correspond with a valid name.
+TEST(ProxyResolverV8Test, IPv6HostnamesNotBracketed) {
+  ProxyResolverV8WithMockBindings resolver;
+  int result = resolver.SetPacScriptFromDisk("resolve_host.js");
+  EXPECT_EQ(OK, result);
+
+  ProxyInfo proxy_info;
+  CapturingBoundNetLog log(CapturingNetLog::kUnbounded);

[mmenke, 2012/02/10 20:53:50]

Doesn't seem to be any reason not to just use a BoundNetLog().

[eroman, 2012/02/10 21:03:53]

Done. I had copy-pasted this without thinking :-)

+  result = resolver.GetProxyForURL(
+      GURL("http://[abcd::efff]:99/watsupdawg"), &proxy_info,
+      CompletionCallback(), NULL, log.bound());
+
+  EXPECT_EQ(OK, result);
+  EXPECT_TRUE(proxy_info.is_direct());
+
+  // We called dnsResolveEx() exactly once, by passing through the "host"
+  // argument to FindProxyForURL(). The brackets should have been stripped.
+  ASSERT_EQ(1U, resolver.mock_js_bindings()->dns_resolves_ex.size());
+  EXPECT_EQ("abcd::efff", resolver.mock_js_bindings()->dns_resolves_ex[0]);
+}
+
 }  // namespace
 }  // namespace net