Fix crash in ExtensionService::InitializePermissions().

Fix crash in ExtensionService::InitializePermissions().

This crash occurs when an unpacked extension changes IDs by adding a key to its manifest. The extension preferences are stored under the old key. This started causing problems because now we record granted permissions for unpacked extensions.

BUG=112301
TEST=ExtensionServiceTest.UnpackedExtensionCanChangeID

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120123

[jstritar, 2012-02-01 21:46:33]

http://codereview.chromium.org/9320021/diff/1/chrome/common/extensions/extens...
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/9320021/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension.cc:2669: }
This method isn't very useful anymore (used in one place). Maybe we should just
get rid of it and check the type directly from InitializePermissions.

It's kind of confusing because LOAD extensions can usually silently increase
permissions, but not always (if it has a plugin when first installing, or when
they use the permissions API).

[Aaron Boodman, 2012-02-01 21:58:37]

lgtm

[Aaron Boodman, 2012-02-02 00:43:51]

As to your question about whether it is OK to increase the size of
Preferences file by always including granted permissions...

I think it would be good to keep the size of the prefs file down as
much as possible. Let's keep it the way you have it now for awhile and
see if it continues to cause problems.

- a

On Wed, Feb 1, 2012 at 1:58 PM,  <aa@chromium.org> wrote:
> lgtm
>
> http://codereview.chromium.org/9320021/