Fix crash in ExtensionService::InitializePermissions().

chrome/browser/extensions/extension_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service_unittest.h"
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
@@ skipping 80 matching lines @@
 const char* const all_zero = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
 const char* const zero_n_one = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaab";
 const char* const good0 = "behllobkkfkfnphdnhnkndlbkcpglgmj";
 const char* const good1 = "hpiknbiabeeppbpihjehijgoemciehgk";
 const char* const good2 = "bjafgdebaacbbbecmhlhpofkepfkgcpa";
 const char* const good_crx = "ldnnhddmnhbkjipkidpdiheffobcpfmf";
 const char* const page_action = "obcimlgaoabeegjmmpldobjndiealpln";
 const char* const theme_crx = "iamefpfkojoapidjnbafmgkgncegbkad";
 const char* const theme2_crx = "pjpgmfcmabopnnfonnhmdjglfpjjfkbf";
 const char* const permissions_crx = "eagpmdpfmaekmmcejjbmjoecnejeiiin";
+const char* const unpacked = "cbcdidchbppangcjoddlpdjlenngjldk";
 
 struct ExtensionsOrder {
   bool operator()(const Extension* a, const Extension* b) {
     return a->name() < b->name();
   }
 };
 
 static std::vector<string16> GetErrors() {
   const std::vector<string16>* errors =
       ExtensionErrorReporter::GetInstance()->GetErrors();
@@ skipping 1777 matching lines @@
   extensions::UnpackedInstaller::Create(service_)->Load(extension_path);
   loop_.RunAllPending();
   EXPECT_EQ(0u, GetErrors().size());
   ASSERT_EQ(1u, loaded_.size());
   EXPECT_EQ(1u, service_->extensions()->size());
   const Extension* theme = *service_->extensions()->begin();
   EXPECT_EQ("name", theme->name());
   EXPECT_EQ("description", theme->description());
 }
 
+// Tests that we can change the ID of an unpacked extension by adding a key
+// to its manifest.
+TEST_F(ExtensionServiceTest, UnpackedExtensionCanChangeID) {
+  InitializeEmptyExtensionService();
+
+  ScopedTempDir temp;
+  ASSERT_TRUE(temp.CreateUniqueTempDir());
+
+  FilePath extension_path = temp.path();
+  FilePath manifest_path = extension_path.Append(Extension::kManifestFilename);
+  FilePath manifest_no_key = data_dir_.
+      AppendASCII("unpacked").
+      AppendASCII("manifest_no_key.json");
+
+  FilePath manifest_with_key = data_dir_.
+      AppendASCII("unpacked").
+      AppendASCII("manifest_with_key.json");
+
+  ASSERT_TRUE(file_util::PathExists(manifest_no_key));
+  ASSERT_TRUE(file_util::PathExists(manifest_with_key));
+
+  // Load the unpacked extension with no key.
+  file_util::CopyFile(manifest_no_key, manifest_path);
+  extensions::UnpackedInstaller::Create(service_)->Load(extension_path);
+
+  loop_.RunAllPending();
+  EXPECT_EQ(0u, GetErrors().size());
+  ASSERT_EQ(1u, loaded_.size());
+  EXPECT_EQ(1u, service_->extensions()->size());
+
+  // Add the key to the manifest.
+  file_util::CopyFile(manifest_with_key, manifest_path);
+  loaded_.clear();
+
+  // Reload the extensions.
+  service_->ReloadExtensions();
+  const Extension* extension = service_->GetExtensionById(unpacked, false);
+  EXPECT_EQ(unpacked, extension->id());
+  ASSERT_EQ(1u, loaded_.size());
+
+  // TODO(jstritar): Right now this just makes sure we don't crash and burn, but
+  // we should also test that preferences are preserved.
+}
+
 TEST_F(ExtensionServiceTest, InstallLocalizedTheme) {
   InitializeEmptyExtensionService();
   FilePath theme_path = data_dir_
       .AppendASCII("theme_i18n");
 
   const Extension* theme = PackAndInstallCRX(theme_path, INSTALL_NEW);
 
   EXPECT_EQ(0u, GetErrors().size());
   EXPECT_EQ(1u, service_->extensions()->size());
   EXPECT_EQ("name", theme->name());
@@ skipping 2835 matching lines @@
   ASSERT_FALSE(AddPendingSyncInstall());
 
   // Wait for the external source to install.
   WaitForCrxInstall(crx_path_, INSTALL_NEW);
   ASSERT_TRUE(IsCrxInstalled());
 
   // Now that the extension is installed, sync request should fail
   // because the extension is already installed.
   ASSERT_FALSE(AddPendingSyncInstall());
 }