chrome/browser/extensions/installed_loader.cc - Issue 9320021: Fix crash in ExtensionService::InitializePermissions().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/installed_loader.cc

Issue 9320021: Fix crash in ExtensionService::InitializePermissions(). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: add the test data Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/installed_loader.cc

diff --git a/chrome/browser/extensions/installed_loader.cc b/chrome/browser/extensions/installed_loader.cc

index 61c17d6e30861920ba3c73f22439dd0b0dcb67de..79cc2e8f85b1551934e6943c934ed3beac1c72f8 100644

--- a/chrome/browser/extensions/installed_loader.cc

+++ b/chrome/browser/extensions/installed_loader.cc

@@ -84,6 +84,7 @@ void InstalledLoader::Load(const ExtensionInfo& info, bool write_to_prefs) {

// Once installed, non-unpacked extensions cannot change their IDs (e.g., by

// updating the 'key' field in their manifest).

+ // TODO(jstritar): migrate preferences when unpacked extensions change IDs.

if (extension &&

extension->location() != Extension::LOAD &&

info.extension_id != extension->id()) {