Issue 9317001: Revert 119769 - Switch AudioDevice classes from SyncSocket to CancelableSyncSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9317001: Revert 119769 - Switch AudioDevice classes from SyncSocket to CancelableSyncSocket. (Closed)

Created:
8 years, 10 months ago by karen

Modified:
8 years, 10 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1025/src/

Visibility:
Public.

More Reviews

Description

Revert 119769 - Switch AudioDevice classes from SyncSocket to CancelableSyncSocket. This fixes the double close issue and makes Stop() instant. Also, this addresses some issues reported by tsan (see bug reports). BUG=103711, 95509 TEST=content_unittests,media_unittests Review URL: http://codereview.chromium.org/9121045 TBR=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119921

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -80 lines)			Patch
M	content/browser/renderer_host/media/audio_input_sync_writer.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/media/audio_input_sync_writer.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/media/audio_sync_reader.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/media/audio_sync_reader.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	content/renderer/media/audio_device.h	View	2 chunks	+28 lines, -1 line	0 comments	Download
M	content/renderer/media/audio_device.cc	View	5 chunks	+11 lines, -18 lines	0 comments	Download
M	content/renderer/media/audio_input_device.h	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	content/renderer/media/audio_input_device.cc	View	12 chunks	+40 lines, -39 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

8 years, 10 months ago (2012-01-31 18:21:42 UTC) #2

On 2012/01/31 18:15:15, karen wrote:

Lgtm

Expand Messages | Collapse Messages