make search box in settings page not get hidden behind enterprise warning

make search box in settings page not get hidden behind enterprise warning

BUG=112206
TEST=search box not covered up


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122187

[James Hawkins, 2012-02-01 02:29:39]

Can you explain the fix?

[Tyler Breisacher (Chromium), 2012-02-01 02:33:43]

On 2012/02/01 02:29:39, James Hawkins wrote:
> Can you explain the fix?

When we show the banner, we push the header (containing the word "Settings" plus
the search box) down by the height of the header. When we hide the banner, we
move the header it back up. We only move the header on the main settings page,
not on any of the subpages, because the banner only shows on the main page. If
we want the banner to show on every page, that might be a little trickier.

[James Hawkins, 2012-02-01 02:36:49]

Can you add an animation?  Also, start a thread with Glen to see if this is an
acceptable solution.

[Glen Murphy, 2012-02-03 21:21:44]

This is fine.

On Tue, Jan 31, 2012 at 6:36 PM,  <jhawkins@chromium.org> wrote:
> Can you add an animation?  Also, start a thread with Glen to see if this is
> an
> acceptable solution.
>
> https://chromiumcodereview.appspot.com/9307026/

[Tyler Breisacher (Chromium), 2012-02-04 02:44:53]

* Added some animation
* Fixed it so that it checks all prefs, not just those on the main page.
* Made the banner show on the search page too, otherwise the search box jumps up
and down when you start searching.

[James Hawkins, 2012-02-05 05:13:10]

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
File chrome/browser/resources/options2/browser_options.js (right):

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/browser_options.js:229: * it triggers the
managed banner to be visible. The banner can be enforced
enforced?  Do you mean 'forced' here?

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/browser_options.js:233:
updateManagedBannerVisibility_: function() {
If this applies to all sub-pages, why is the implementation now in
BrowserOptions?

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
File chrome/browser/resources/options2/options.html (right):

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/options.html:109: <div
id="managed-prefs-banner" class="managed-prefs-banner hidden">
Why did you make 'hidden' a class?

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
File chrome/browser/resources/options2/options_page.css (right):

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/options_page.css:46:
-webkit-transition-duration: 500ms;
500ms is too long.  Use 200ms.

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/options_page.css:323: z-index: 2;
What is this change about?

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/options_page.css:326:
.managed-prefs-banner.hidden {
.managed-prefs-banner['hidden']

[Tyler Breisacher (Chromium), 2012-02-06 18:46:50]

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
File chrome/browser/resources/options2/browser_options.js (right):

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/browser_options.js:229: * it triggers the
managed banner to be visible. The banner can be enforced
This part of the comment is copied from the original in options_page.js. I'm not
sure what the comment was trying to say. I'll look into it.

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/browser_options.js:233:
updateManagedBannerVisibility_: function() {
The banner only *shows* on the BrowserOptions page, but it reflects the presence
of managed prefs on *any* page.

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
File chrome/browser/resources/options2/options.html (right):

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/options.html:109: <div
id="managed-prefs-banner" class="managed-prefs-banner hidden">
As far as I can tell, if we use the "hidden" attribute instead, then the
animation doesn't work.

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
File chrome/browser/resources/options2/options_page.css (right):

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/options_page.css:46:
-webkit-transition-duration: 500ms;
On 2012/02/05 05:13:10, James Hawkins wrote:
> 500ms is too long.  Use 200ms.

Done.

[Tyler Breisacher (Chromium), 2012-02-06 19:08:58]

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
File chrome/browser/resources/options2/browser_options.js (right):

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/browser_options.js:229: * it triggers the
managed banner to be visible. The banner can be enforced
On 2012/02/05 05:13:10, James Hawkins wrote:
> enforced?  Do you mean 'forced' here?

I'm not sure what the 'managed flag of this class' is. I can't find any such
flag in options_page.js -- it sounds like this is referring to code that no
longer exists.

[James Hawkins, 2012-02-09 04:41:45]

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
File chrome/browser/resources/options2/options.html (right):

https://chromiumcodereview.appspot.com/9307026/diff/3003/chrome/browser/resou...
chrome/browser/resources/options2/options.html:109: <div
id="managed-prefs-banner" class="managed-prefs-banner hidden">
On 2012/02/06 18:46:50, Tyler Breisacher wrote:
> As far as I can tell, if we use the "hidden" attribute instead, then the
> animation doesn't work.

Why not?

blah[hidden] {
  height: 0;
}

Nothing else needs to change.

https://chromiumcodereview.appspot.com/9307026/diff/13002/chrome/browser/reso...
File chrome/browser/resources/options2/browser_options.js (right):

https://chromiumcodereview.appspot.com/9307026/diff/13002/chrome/browser/reso...
chrome/browser/resources/options2/browser_options.js:241: * it triggers the
managed banner to be visible.
@private

[Tyler Breisacher (Chromium), 2012-02-13 22:16:21]

> Why not?
> 
> blah[hidden] {
>   height: 0;
> }
> 
> Nothing else needs to change.

Yup, that works.

[James Hawkins, 2012-02-15 22:02:04]

lgtm

[commit-bot: I haz the power, 2012-02-15 22:04:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9307026/18019

[commit-bot: I haz the power, 2012-02-15 23:50:57]

Change committed as 122187