chrome/browser/resources/options2/options.html - Issue 9307026: make search box in settings page not get hidden behind enterprise warning

Side by Side Diff: chrome/browser/resources/options2/options.html

Issue 9307026: make search box in settings page not get hidden behind enterprise warning (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: make the banner show on the search page as well Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/options2/browser_options.js ('K') | « chrome/browser/resources/options2/content_settings.js ('k') | chrome/browser/resources/options2/options_page.css » ('j') | chrome/browser/resources/options2/options_page.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html id="t" i18n-values="dir:textdirection">	2 <html id="t" i18n-values="dir:textdirection">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title i18n-content="optionsPageTitle"></title>	5 <title i18n-content="optionsPageTitle"></title>

6	6

7 <link rel="icon" href="chrome://theme/IDR_SETTINGS_FAVICON">	7 <link rel="icon" href="chrome://theme/IDR_SETTINGS_FAVICON">

8 <link rel="stylesheet" href="chrome://resources/css/list.css">	8 <link rel="stylesheet" href="chrome://resources/css/list.css">

9 <link rel="stylesheet" href="chrome://resources/css/overlay.css">	9 <link rel="stylesheet" href="chrome://resources/css/overlay.css">

10 <link rel="stylesheet" href="chrome://resources/css/select.css">	10 <link rel="stylesheet" href="chrome://resources/css/select.css">

(...skipping 88 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99 </if>	99 </if>

100 <if expr="not pp_ifdef('win32') and not pp_ifdef('darwin')">	100 <if expr="not pp_ifdef('win32') and not pp_ifdef('darwin')">

101 <include src="certificate_restore_overlay.html">	101 <include src="certificate_restore_overlay.html">

102 <include src="certificate_backup_overlay.html">	102 <include src="certificate_backup_overlay.html">

103 <include src="certificate_edit_ca_trust_overlay.html">	103 <include src="certificate_edit_ca_trust_overlay.html">

104 <include src="certificate_import_error_overlay.html">	104 <include src="certificate_import_error_overlay.html">

105 </if>	105 </if>

106 </div>	106 </div>

107 <div id="main-content">	107 <div id="main-content">

108 <div id="mainview">	108 <div id="mainview">

109 <div id="managed-prefs-banner" class="managed-prefs-banner" hidden>	109 <div id="managed-prefs-banner" class="managed-prefs-banner hidden">
	James Hawkins 2012/02/05 05:13:10 Why did you make 'hidden' a class? Why did you make 'hidden' a class? Tyler Breisacher (Chromium) 2012/02/06 18:46:50 As far as I can tell, if we use the "hidden" attri As far as I can tell, if we use the "hidden" attribute instead, then the animation doesn't work. James Hawkins 2012/02/09 04:41:45 Why not? blah[hidden] { height: 0; } Nothing e Show quoted text On 2012/02/06 18:46:50, Tyler Breisacher wrote: > As far as I can tell, if we use the "hidden" attribute instead, then the > animation doesn't work. Why not? blah[hidden] { height: 0; } Nothing else needs to change.
110 <span id="managed-prefs-icon" class="managed-prefs-icon"></span>	110 <span id="managed-prefs-icon" class="managed-prefs-icon"></span>

111 <span id="managed-prefs-text" class="managed-prefs-text"></span>	111 <span id="managed-prefs-text" class="managed-prefs-text"></span>

112 </div>	112 </div>

113 <div id="subpage-backdrop" class="overlay" hidden></div>	113 <div id="subpage-backdrop" class="overlay" hidden></div>

114 <div id="mainview-content">	114 <div id="mainview-content">

115 <div id="page-container">	115 <div id="page-container">

116 <!-- Please keep the main pages in desired order of display. This will	116 <!-- Please keep the main pages in desired order of display. This will

117 allow search results to display in the desired order. -->	117 allow search results to display in the desired order. -->

118 <include src="search_page.html">	118 <include src="search_page.html">

119 <include src="browser_options.html">	119 <include src="browser_options.html">

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
178 </div>	178 </div>

179 </div>	179 </div>

180 </div>	180 </div>

181 </div>	181 </div>

182 </div>	182 </div>

183 <script src="chrome://settings-frame/strings.js"></script>	183 <script src="chrome://settings-frame/strings.js"></script>

184 <script src="chrome://resources/js/i18n_template.js"></script>	184 <script src="chrome://resources/js/i18n_template.js"></script>

185 <script src="chrome://resources/js/i18n_process.js"></script>	185 <script src="chrome://resources/js/i18n_process.js"></script>

186 </body>	186 </body>

187 </html>	187 </html>

OLD	NEW