Use an enum in embedded_names as input to JS_GET_NAME.

Use an enum in embedded_names as input to JS_GET_NAME.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43869

Reverted: https://code.google.com/p/dart/source/detail?r=43943

[floitsch, 2015-02-18 13:00:44]

LGTM!

(in the future we should make the entries lower-case, and potentially change the
name, but start by shipping this).
Maybe add a TODO.

https://chromiumcodereview.appspot.com/929313002/diff/1/pkg/compiler/lib/src/...
File pkg/compiler/lib/src/js_backend/namer.dart (right):

https://chromiumcodereview.appspot.com/929313002/diff/1/pkg/compiler/lib/src/...
pkg/compiler/lib/src/js_backend/namer.dart:320: assert(invariant(node, "Missing
JsGetName value in namer!"));
Keep the 'compiler.reportError'.

[herhut, 2015-02-19 10:27:28]

https://codereview.chromium.org/929313002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/namer.dart (right):

https://codereview.chromium.org/929313002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/namer.dart:320: assert(invariant(node, "Missing
JsGetName value in namer!"));
On 2015/02/18 13:00:44, floitsch wrote:
> Keep the 'compiler.reportError'.

Done.

[herhut, 2015-02-19 10:27:51]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[herhut, 2015-02-19 10:28:43]

Committed patchset #2 (id:20001) manually as 43869 (presubmit successful).

[sra1, 2015-02-19 17:52:52]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-02-19 17:52:52]

I'm not sure what the motivation for this change is.
The comment does not say.

However, is has a serious impact on some benchmarks so it needs to be pulled for
fixed for 1.9