Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart

Issue 929313002: Use an enum in embedded_names as input to JS_GET_NAME. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase + comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/_internal/compiler/js_lib/js_names.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// Contains the names of globals that are embedded into the output by the 5 /// Contains the names of globals that are embedded into the output by the
6 /// compiler. 6 /// compiler.
7 /// 7 ///
8 /// Variables embedded this way should be access with `JS_EMBEDDED_GLOBAL` from 8 /// Variables embedded this way should be access with `JS_EMBEDDED_GLOBAL` from
9 /// the `_foreign_helper` library. 9 /// the `_foreign_helper` library.
10 /// 10 ///
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 /// only contain one Dart isolate. 51 /// only contain one Dart isolate.
52 const CREATE_NEW_ISOLATE = 'createNewIsolate'; 52 const CREATE_NEW_ISOLATE = 'createNewIsolate';
53 53
54 const CLASS_ID_EXTRACTOR = 'classIdExtractor'; 54 const CLASS_ID_EXTRACTOR = 'classIdExtractor';
55 const CLASS_FIELDS_EXTRACTOR = 'classFieldsExtractor'; 55 const CLASS_FIELDS_EXTRACTOR = 'classFieldsExtractor';
56 const INSTANCE_FROM_CLASS_ID = "instanceFromClassId"; 56 const INSTANCE_FROM_CLASS_ID = "instanceFromClassId";
57 const INITIALIZE_EMPTY_INSTANCE = "initializeEmptyInstance"; 57 const INITIALIZE_EMPTY_INSTANCE = "initializeEmptyInstance";
58 const TYPEDEF_TYPE_PROPERTY_NAME = r"$typedefType"; 58 const TYPEDEF_TYPE_PROPERTY_NAME = r"$typedefType";
59 const TYPEDEF_PREDICATE_PROPERTY_NAME = r"$$isTypedef"; 59 const TYPEDEF_PREDICATE_PROPERTY_NAME = r"$$isTypedef";
60 const NATIVE_SUPERCLASS_TAG_NAME = r"$nativeSuperclassTag"; 60 const NATIVE_SUPERCLASS_TAG_NAME = r"$nativeSuperclassTag";
61 const ARGUMENT_COUNT_PROPERTY = r"$argumentCount";
62 const DEFAULT_VALUES_PROPERTY = r"$defaultValues";
63 61
64 /// Returns the type given the name of a class. 62 /// Returns the type given the name of a class.
65 /// This function is called by the runtime when computing rti. 63 /// This function is called by the runtime when computing rti.
66 const GET_TYPE_FROM_NAME = 'getTypeFromName'; 64 const GET_TYPE_FROM_NAME = 'getTypeFromName';
67 const TYPE_TO_INTERCEPTOR_MAP = "typeToInterceptorMap"; 65 const TYPE_TO_INTERCEPTOR_MAP = "typeToInterceptorMap";
68 66
67 /// Names that are supported by [JS_GET_NAME].
68 // TODO(herhut): Make entries lower case (as in fields) and find a better name.
69 enum JsGetName {
70 GETTER_PREFIX,
71 SETTER_PREFIX,
72 CALL_PREFIX,
73 CALL_CATCH_ALL,
74 REFLECTABLE,
75 CLASS_DESCRIPTOR_PROPERTY,
76 REQUIRED_PARAMETER_PROPERTY,
77 DEFAULT_VALUES_PROPERTY,
78 CALL_NAME_PROPERTY
79 }
80
81
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/js_lib/js_names.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698