Use an enum in embedded_names as input to JS_GET_NAME.

sdk/lib/_internal/compiler/js_lib/js_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library _js_helper;
 
 import 'dart:_async_await_error_codes' as async_error_codes;
 
 import 'dart:_js_embedded_names' show
+    JsGetName,
     GET_TYPE_FROM_NAME,
     GET_ISOLATE_TAG,
     INTERCEPTED_NAMES,
     INTERCEPTORS_BY_TAG,
     LEAF_TAGS,
     METADATA,
     DEFERRED_LIBRARY_URIS,
     DEFERRED_LIBRARY_HASHES,
     INITIALIZE_LOADED_HUNK,
     IS_HUNK_LOADED,
@@ skipping 1007 matching lines @@
     if (namedArguments != null && !namedArguments.isEmpty) {
       namedArguments.forEach((String name, argument) {
         names = '$names\$$name';
         namedArgumentList.add(name);
         arguments.add(argument);
         argumentCount++;
       });
     }
 
     String selectorName =
-      '${JS_GET_NAME("CALL_PREFIX")}\$$argumentCount$names';
+      '${JS_GET_NAME(JsGetName.CALL_PREFIX)}\$$argumentCount$names';
 
     return function.noSuchMethod(
         createUnmangledInvocationMirror(
             #call,
             selectorName,
             JSInvocationMirror.METHOD,
             arguments,
             namedArgumentList));
   }
 
   static applyFunctionNewEmitter(Function function,
                                  List positionalArguments,
                                  Map<String, dynamic> namedArguments) {
     if (namedArguments == null) {
       int requiredParameterCount = JS('int', r'#[#]', function,
-          JS_GET_NAME("REQUIRED_PARAMETER_PROPERTY"));
+          JS_GET_NAME(JsGetName.REQUIRED_PARAMETER_PROPERTY));
       int argumentCount = positionalArguments.length;
       if (argumentCount < requiredParameterCount) {
         return functionNoSuchMethod(function, positionalArguments, null);
       }
-      String selectorName = '${JS_GET_NAME("CALL_PREFIX")}\$$argumentCount';
+      String selectorName =
+          '${JS_GET_NAME(JsGetName.CALL_PREFIX)}\$$argumentCount';
       var jsStub = JS('var', r'#[#]', function, selectorName);
       if (jsStub == null) {
         // Do a dynamic call.
         var interceptor = getInterceptor(function);
         var jsFunction = JS('', '#[#]', interceptor,
-            JS_GET_NAME('CALL_CATCH_ALL'));
+            JS_GET_NAME(JsGetName.CALL_CATCH_ALL));
         var defaultValues = JS('var', r'#[#]', function,
-            JS_GET_NAME("DEFAULT_VALUES_PROPERTY"));
+            JS_GET_NAME(JsGetName.DEFAULT_VALUES_PROPERTY));
         if (!JS('bool', '# instanceof Array', defaultValues)) {
           // The function expects named arguments!
           return functionNoSuchMethod(function, positionalArguments, null);
         }
         int defaultsLength = JS('int', "#.length", defaultValues);
         int maxArguments = requiredParameterCount + defaultsLength;
         if (argumentCount > maxArguments) {
           // The function expects less arguments!
           return functionNoSuchMethod(function, positionalArguments, null);
         }
         List arguments = new List.from(positionalArguments);
         List missingDefaults = JS('JSArray', '#.slice(#)', defaultValues,
             argumentCount - requiredParameterCount);
         arguments.addAll(missingDefaults);
         return JS('var', '#.apply(#, #)', jsFunction, function, arguments);
       }
       return JS('var', '#.apply(#, #)', jsStub, function, positionalArguments);
     } else {
       var interceptor = getInterceptor(function);
       var jsFunction = JS('', '#[#]', interceptor,
-          JS_GET_NAME('CALL_CATCH_ALL'));
+          JS_GET_NAME(JsGetName.CALL_CATCH_ALL));
       var defaultValues = JS('JSArray', r'#[#]', function,
-          JS_GET_NAME("DEFAULT_VALUES_PROPERTY"));
+          JS_GET_NAME(JsGetName.DEFAULT_VALUES_PROPERTY));
       List keys = JS('JSArray', r'Object.keys(#)', defaultValues);
       List arguments = new List.from(positionalArguments);
       int used = 0;
       for (String key in keys) {
         var value = namedArguments[key];
         if (value != null) {
           used++;
           arguments.add(value);
         } else {
           arguments.add(JS('var', r'#[#]', defaultValues, key));
@@ skipping 31 matching lines @@
       if (JS('bool', '# instanceof Array', positionalArguments)) {
         arguments = positionalArguments;
       } else {
         arguments = new List.from(positionalArguments);
       }
       argumentCount = JS('int', '#.length', arguments);
     } else {
       arguments = [];
     }
 
-    String selectorName = '${JS_GET_NAME("CALL_PREFIX")}\$$argumentCount';
+    String selectorName =
+        '${JS_GET_NAME(JsGetName.CALL_PREFIX)}\$$argumentCount';
     var jsFunction = JS('var', '#[#]', function, selectorName);
     if (jsFunction == null) {
       var interceptor = getInterceptor(function);
       jsFunction = JS('', '#["call*"]', interceptor);
 
       if (jsFunction == null) {
         return functionNoSuchMethod(function, positionalArguments, null);
       }
       ReflectionInfo info = new ReflectionInfo(jsFunction);
       int maxArgumentCount = info.requiredParameterCount +
@@ skipping 15 matching lines @@
   static applyFunctionWithNamedArguments(Function function,
                                          List positionalArguments,
                                          Map<String, dynamic> namedArguments) {
     if (namedArguments.isEmpty) {
       return applyFunctionWithPositionalArguments(
           function, positionalArguments);
     }
     // TODO(ahe): The following code can be shared with
     // JsInstanceMirror.invoke.
     var interceptor = getInterceptor(function);
-    var jsFunction = JS('', '#[#]', interceptor, JS_GET_NAME('CALL_CATCH_ALL'));
+    var jsFunction = JS('', '#[#]', interceptor,
+        JS_GET_NAME(JsGetName.CALL_CATCH_ALL));
 
     if (jsFunction == null) {
       return functionNoSuchMethod(
           function, positionalArguments, namedArguments);
     }
     ReflectionInfo info = new ReflectionInfo(jsFunction);
     if (info == null || !info.areOptionalParametersNamed) {
       return functionNoSuchMethod(
           function, positionalArguments, namedArguments);
     }
@@ skipping 864 matching lines @@
                      String propertyName) {
     JS_EFFECT(() {
       BoundClosure.receiverOf(JS('BoundClosure', 'void 0'));
       BoundClosure.selfOf(JS('BoundClosure', 'void 0'));
     });
     // TODO(ahe): All the place below using \$ should be rewritten to go
     // through the namer.
     var function = JS('', '#[#]', functions, 0);
     String name = JS('String|Null', '#.\$stubName', function);
     String callName = JS('String|Null', '#[#]', function,
-        JS_GET_NAME("CALL_NAME_PROPERTY"));
+        JS_GET_NAME(JsGetName.CALL_NAME_PROPERTY));
 
     var functionType;
     if (reflectionInfo is List) {
       JS('', '#.\$reflectionInfo = #', function, reflectionInfo);
       ReflectionInfo info = new ReflectionInfo(function);
       functionType = info.functionType;
     } else {
       functionType = reflectionInfo;
     }
 
@@ skipping 82 matching lines @@
     } else {
       throw 'Error in reflectionInfo.';
     }
 
     JS('', '#[#] = #', prototype, JS_SIGNATURE_NAME(), signatureFunction);
 
     JS('', '#[#] = #', prototype, callName, trampoline);
     for (int i = 1; i < functions.length; i++) {
       var stub = functions[i];
       var stubCallName = JS('String|Null', '#[#]', stub,
-          JS_GET_NAME("CALL_NAME_PROPERTY"));
+          JS_GET_NAME(JsGetName.CALL_NAME_PROPERTY));
       if (stubCallName != null) {
         JS('', '#[#] = #', prototype, stubCallName,
            isStatic ? stub : forwardCallTo(receiver, stub, isIntercepted));
       }
     }
 
-    JS('', '#[#] = #', prototype, JS_GET_NAME('CALL_CATCH_ALL'), trampoline);
-    String reqArgProperty = JS_GET_NAME("REQUIRED_PARAMETER_PROPERTY");
-    String defValProperty = JS_GET_NAME("DEFAULT_VALUES_PROPERTY");
+    JS('', '#[#] = #', prototype, JS_GET_NAME(JsGetName.CALL_CATCH_ALL),
+        trampoline);
+    String reqArgProperty = JS_GET_NAME(JsGetName.REQUIRED_PARAMETER_PROPERTY);
+    String defValProperty = JS_GET_NAME(JsGetName.DEFAULT_VALUES_PROPERTY);
     JS('', '#.# = #.#', prototype, reqArgProperty, function, reqArgProperty);
     JS('', '#.# = #.#', prototype, defValProperty, function, defValProperty);
 
     return constructor;
   }
 
   static cspForwardCall(int arity, bool isSuperCall, String stubName,
                         function) {
     var getSelf = RAW_DART_FUNCTION_REF(BoundClosure.selfOf);
     // Handle intercepted stub-names with the default slow case.
@@ skipping 1658 matching lines @@
   // This is a function that will return a helper function that does the
   // iteration of the sync*.
   //
   // Each invocation should give a body with fresh state.
   final dynamic /* js function */ _outerHelper;
 
   SyncStarIterable(this._outerHelper);
 
   Iterator get iterator => new SyncStarIterator(JS('', '#()', _outerHelper));
 }